public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <len.brown@intel.com>
To: john stultz <johnstul@us.ibm.com>
Cc: "Prakash K. Cheemplavam" <PrakashKC@gmx.de>,
	lkml <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
	Dominik Brodowski <linux@brodo.de>
Subject: Re: ACPI PM Timer vs. C1 halt issue
Date: 10 Mar 2004 17:11:51 -0500	[thread overview]
Message-ID: <1078956711.2557.72.camel@dhcppc4> (raw)
In-Reply-To: <1078955372.2696.23.camel@cog.beaverton.ibm.com>

Yes, C1 is the name they gave for what the idle loop does automatically.

this should be monitor/mwait -- if available -- but currently in ACPI
mode C1 is hard-coded to use HALT -- a bug.

http://bugzilla.kernel.org/show_bug.cgi?id=2280

So if your processor has monitor/mwait, and C1 is the best idle state it
has, then you'll probably actually run cooler right now in idle if you
do not load the acpi processor driver.  (but if you've got C2, it should
do better than C1 anyway)

That said, I don't know what caused the regression you describe. 
Perhaps you can clarfiy the minimal changes necessary to switch between
correct and incorrect behaviour?

thanks,
-Len

On Wed, 2004-03-10 at 16:49, john stultz wrote:
> On Tue, 2004-03-09 at 14:45, Prakash K. Cheemplavam wrote:
> > john stultz wrote:
> > > On Tue, 2004-03-09 at 13:35, Prakash K. Cheemplavam wrote:
> > > 
> > >>I found out what causes higher idle temps when using mm-sources and 
> > >>2.6.4-rc vanilla sources: If I use PM Timer as timesource, it seems the 
> > >>C1 halt isn't properly called, at least CPU disconnect doesn't seem to 
> > >>work, thus leaving my CPU as hot as without disconnect.
> > [snip]
> > > 
> > > Sounds like a bug. I'm not very familiar w/ the ACPI cpu power states,
> > > is there anything you have to do to trigger C1 Halt? Or is it just
> > > called in the idle loop?
> > 
> > It should be called within the idle loop.
> 
> Hmm. I'm still stumped. Looking at acpi_processor_idle(), the C1 state
> doesn't touch the ACPI PM timer. The C2 and C3 states do, but they just
> read.  
> 
> Dominik: Do you have a clue on this?
> 
> thanks
> -john
> 


  reply	other threads:[~2004-03-10 22:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-09 21:35 ACPI PM Timer vs. C1 halt issue Prakash K. Cheemplavam
2004-03-09 22:11 ` john stultz
2004-03-09 22:45   ` Prakash K. Cheemplavam
2004-03-10 21:49     ` john stultz
2004-03-10 22:11       ` Len Brown [this message]
2004-03-10 22:48         ` Prakash K. Cheemplavam
2004-03-11  0:15           ` Thomas Schlichter
2004-03-11  8:47             ` Prakash K. Cheemplavam
2004-03-11 13:46               ` Thomas Schlichter
2004-03-11 14:23                 ` Prakash K. Cheemplavam
2004-03-10 22:53         ` Prakash K. Cheemplavam
2004-03-11 18:14         ` Prakash K. Cheemplavam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1078956711.2557.72.camel@dhcppc4 \
    --to=len.brown@intel.com \
    --cc=PrakashKC@gmx.de \
    --cc=akpm@osdl.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@brodo.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox