From: Albert Cahalan <albert@users.sf.net>
To: linux-kernel mailing list <linux-kernel@vger.kernel.org>
Cc: hirofumi@mail.parknet.co.jp, areiter@preventsys.com,
rmk+serial@arm.linux.org.uk, tytso@mit.edu
Subject: Subject: Re: NULL pointer in proc_pid_stat -- oops.
Date: 28 Mar 2004 20:35:46 -0500 [thread overview]
Message-ID: <1080524145.2233.1877.camel@cube> (raw)
>> And from the oops trace output (that is attached), we can
>> see that %edx is 0x0; so we can easily see here why we're
>> crashing at least. After examining the C source, I see
>> that we're dying in the call to task_name() (inline) from
>> proc_pid_stat().
>
> Looks like this problem is same with BSD acct Oops.
>
> if (task->tty) {
> tty_pgrp = task->tty->pgrp;
> tty_nr = new_encode_dev(tty_devnum(task->tty));
> }
>
> Some place doesn't take the any lock for ->tty.
> I think we need to take the lock for ->tty.
Probably this isn't the thing for 2.6.xx, but how
about a special tty struct instead of the NULL?
Make it const, perhaps write-protected, etc.
Then the if(task->tty) test can be removed.
next reply other threads:[~2004-03-29 1:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-29 1:35 Albert Cahalan [this message]
2004-03-29 14:18 ` Subject: Re: NULL pointer in proc_pid_stat -- oops OGAWA Hirofumi
2004-03-29 17:09 ` Ricky Beam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1080524145.2233.1877.camel@cube \
--to=albert@users.sf.net \
--cc=areiter@preventsys.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox