The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Chris Mason <mason@suse.com>
To: "Stephen C. Tweedie" <sct@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Andreas Dilger <adilger@clusterfs.com>
Subject: Re: [EXT3/JBD] Periodic journal flush not enough?
Date: Mon, 29 Mar 2004 14:16:36 -0500	[thread overview]
Message-ID: <1080587796.28604.12.camel@watt.suse.com> (raw)
In-Reply-To: <1080586577.2285.107.camel@sisko.scot.redhat.com>

On Mon, 2004-03-29 at 13:56, Stephen C. Tweedie wrote:

> Sounds like it's due to the "b_committed_data" avoidance code.  Ext3
> cannot immediately reuse disk space after a delete, because of lazy
> writeback --- until the final writeback of the delete hits disk, we have
> to be able to undo it.  And because in non-data-journaled modes we allow
> new disk writes to hit disk before a transaction commit, that means we
> can't reuse deleted blocks until after they are committed.
> 
> I've never seen it reported as a problem outside of artificial test
> scenarios, but if it is something we need to address, Andreas Dilger's
> patch looks good.

Just FYI, reiserfs does something slightly different.  When
reiserfs_file_write and get_block routines see -ENOSPC, they get things
into a consistent state, commit the running transaction and try again
(once).  It didn't end up very complex...

-chris



  reply	other threads:[~2004-03-29 19:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-26 23:19 [EXT3/JBD] Periodic journal flush not enough? Herbert Xu
2004-03-26 23:48 ` Andrew Morton
2004-03-27  0:01   ` Herbert Xu
2004-03-29 18:56   ` Stephen C. Tweedie
2004-03-29 19:16     ` Chris Mason [this message]
2004-03-26 23:55 ` Andreas Dilger
2004-03-29 20:03   ` Stephen C. Tweedie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1080587796.28604.12.camel@watt.suse.com \
    --to=mason@suse.com \
    --cc=adilger@clusterfs.com \
    --cc=akpm@osdl.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox