Re: ACPI battery problem with 2.6.1-rc1-mm2 kernel patch

Re: ACPI battery problem with 2.6.1-rc1-mm2 kernel patch

[Len Brown]

On Mon, 2004-03-29 at 10:46, Dax Kelson wrote:
> On Mon, 2004-01-05 at 19:59, Valdis.Kletnieks@vt.edu wrote:
> > On Mon, 05 Jan 2004 18:08:59 PST, Andrew Morton said:
> > 
> > > Thanks, the acpi-20031203 patch seems to have introduced a handful
> of
> > > regressions.
> > 
> > As suggested by Yu Luming, the patch at
> http://bugzilla.kernel.org/show_bug.cgi?id=1766
> > is confirmed to fix my issue.  2.6.1-rc1-mm2 with that patch gives
> me:
> 
> Just confirming that the same patched fixed up the battery reporting
> problems on my laptop as well.

While I'm happy that patches backported to 2.6.0 and 2.6.1
work properly, is is probably more valuable to the community
to know that the latest 2.6 release works -- particularly since
the fix in question was integrated into the baseline 6 weeks ago.

thanks,
-Len

RE: ACPI battery problem with 2.6.1-rc1-mm2 kernel patch

[Yu, Luming]

>I admit that although *my* configuration works now, somebody else who
understands
>the code better (Yu Luming and Len Brown, probably) get to decide if
it's an "obvious"
>fix or something that introduces other issues.  I know back around
2.5.68, there was a
>2-line change to the Cardbus support that broke my Xircom card, but
backing it out
>was technically wrong as well - the proper fix involved a complete
re-write of the Yenta
>stuff.

Actually, that fix is not perfect. But this is not like cardbus case you
mentioned.
I just want to do it better.

RE: ACPI battery problem with 2.6.1-rc1-mm2 kernel patch

[Yu, Luming]

> > As suggested by Yu Luming, the patch at
http://bugzilla.kernel.org/show_bug.cgi?id=1766
> > is confirmed to fix my issue.  2.6.1-rc1-mm2 with that patch gives
me:
> 
> Just confirming that the same patched fixed up the battery reporting
> problems on my laptop as well.
>
>Works for me too. Case closed?

Is there similar battery issues on any IBM Thinkpad Laptop?

ACPI battery problem with 2.6.1-rc1-mm2 kernel patch

[Jean-Marc Valin]

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

Hi,

I've just tried 2.6.1-rc1-mm2 and noticed that I can no longer get the
battery status through ACPI (/proc/acpi/battery/BAT0/state reports only
zeros). While my dsdt may be a bit buggy, it worked fine with 2.6.1-rc1,
so there seems to be a regression somewhere. I haven't tried earlier -mm
patches though.

I'm running Fedora Core 1 on Dell Latitute D600 (Pentium M 1.6, 1 GB
RAM). I can do more testing if that's useful.

	Jean-Marc

-- 
Jean-Marc Valin, M.Sc.A., ing. jr.
LABORIUS (http://www.gel.usherb.ca/laborius)
Université de Sherbrooke, Québec, Canada

[-- Attachment #2: Ceci est une partie de message numériquement signée. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: ACPI battery problem with 2.6.1-rc1-mm2 kernel patch

[Andrew Morton]

Jean-Marc Valin <Jean-Marc.Valin@USherbrooke.ca> wrote:
>
> Hi,
> 
> I've just tried 2.6.1-rc1-mm2 and noticed that I can no longer get the
> battery status through ACPI (/proc/acpi/battery/BAT0/state reports only
> zeros). While my dsdt may be a bit buggy, it worked fine with 2.6.1-rc1,
> so there seems to be a regression somewhere. I haven't tried earlier -mm
> patches though.
> 
> I'm running Fedora Core 1 on Dell Latitute D600 (Pentium M 1.6, 1 GB
> RAM). I can do more testing if that's useful.
> 

Thanks, the acpi-20031203 patch seems to have introduced a handful of
regressions.

Re: ACPI battery problem with 2.6.1-rc1-mm2 kernel patch

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

On Mon, 05 Jan 2004 18:08:59 PST, Andrew Morton said:

> Thanks, the acpi-20031203 patch seems to have introduced a handful of
> regressions.

As suggested by Yu Luming, the patch at http://bugzilla.kernel.org/show_bug.cgi?id=1766
is confirmed to fix my issue.  2.6.1-rc1-mm2 with that patch gives me:

%  cat /proc/acpi/battery/BAT0/state 
present:                 yes
capacity state:          ok
charging state:          unknown
present rate:            unknown
remaining capacity:      66000 mWh
present voltage:         16548 mV
% cat /proc/acpi/battery/BAT0/info  
present:                 yes
design capacity:         66000 mWh
last full capacity:      62400 mWh
battery technology:      rechargeable
design voltage:          14800 mV
design capacity warning: 3000 mWh
design capacity low:     1000 mWh
capacity granularity 1:  200 mWh
capacity granularity 2:  200 mWh
model number:            0004M778
serial number:           1084
battery type:            LION
OEM info:                SANYO


[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: ACPI battery problem with 2.6.1-rc1-mm2 kernel patch

[Dax Kelson]

On Mon, 2004-01-05 at 19:59, Valdis.Kletnieks@vt.edu wrote:
> On Mon, 05 Jan 2004 18:08:59 PST, Andrew Morton said:
> 
> > Thanks, the acpi-20031203 patch seems to have introduced a handful of
> > regressions.
> 
> As suggested by Yu Luming, the patch at http://bugzilla.kernel.org/show_bug.cgi?id=1766
> is confirmed to fix my issue.  2.6.1-rc1-mm2 with that patch gives me:

Just confirming that the same patched fixed up the battery reporting
problems on my laptop as well.

Dax Kelson
Guru Labs

Re: ACPI battery problem with 2.6.1-rc1-mm2 kernel patch

[Jean-Marc Valin]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

> > As suggested by Yu Luming, the patch at http://bugzilla.kernel.org/show_bug.cgi?id=1766
> > is confirmed to fix my issue.  2.6.1-rc1-mm2 with that patch gives me:
> 
> Just confirming that the same patched fixed up the battery reporting
> problems on my laptop as well.

Works for me too. Case closed?

	Jean-Marc

-- 
Jean-Marc Valin, M.Sc.A., ing. jr.
LABORIUS (http://www.gel.usherb.ca/laborius)
Université de Sherbrooke, Québec, Canada

[-- Attachment #2: Ceci est une partie de message numériquement signée. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: ACPI battery problem with 2.6.1-rc1-mm2 kernel patch

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

On Tue, 06 Jan 2004 03:23:13 EST, Jean-Marc Valin said:
> > > As suggested by Yu Luming, the patch at http://bugzilla.kernel.org/show=_bug.cgi?id=3D1766
> > > is confirmed to fix my issue.  2.6.1-rc1-mm2 with that patch gives me:
> >
> > Just confirming that the same patched fixed up the battery reporting
> > problems on my laptop as well.
> 
> Works for me too. Case closed?

I admit that although *my* configuration works now, somebody else who understands
the code better (Yu Luming and Len Brown, probably) get to decide if it's an "obvious"
fix or something that introduces other issues.  I know back around 2.5.68, there was a
2-line change to the Cardbus support that broke my Xircom card, but backing it out
was technically wrong as well - the proper fix involved a complete re-write of the Yenta
stuff.

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: ACPI battery problem with 2.6.1-rc1-mm2 kernel patch

[Jean-Marc Valin]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

> > As suggested by Yu Luming, the patch at http://bugzilla.kernel.org/show_bug.cgi?id=1766
> > is confirmed to fix my issue.  2.6.1-rc1-mm2 with that patch gives me:
> 
> Just confirming that the same patched fixed up the battery reporting
> problems on my laptop as well.

Works for me too. Case closed?

	Jean-Marc

-- 
Jean-Marc Valin, M.Sc.A., ing. jr.
LABORIUS (http://www.gel.usherb.ca/laborius)
Université de Sherbrooke, Québec, Canada

[-- Attachment #2: Ceci est une partie de messagenumériquement signée. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: ACPI battery problem with 2.6.1-rc1-mm2 kernel patch

[Dax Kelson]

On Mon, 2004-01-05 at 19:59, Valdis.Kletnieks@vt.edu wrote:
> On Mon, 05 Jan 2004 18:08:59 PST, Andrew Morton said:
> 
> > Thanks, the acpi-20031203 patch seems to have introduced a handful of
> > regressions.
> 
> As suggested by Yu Luming, the patch at http://bugzilla.kernel.org/show_bug.cgi?id=1766
> is confirmed to fix my issue.  2.6.1-rc1-mm2 with that patch gives me:

Just confirming that the same patched fixed up the battery reporting
problems on my laptop as well.

Dax Kelson
Guru Labs