Re: [PATCH] mask ADT: new mask.h file [2/22]

[Matthew Dobson <colpatch@us.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

On Mon, 2004-03-29 at 04:12, Paul Jackson wrote:
> Patch_2_of_22 - New mask ADT
> 	Adds new include/linux/mask.h header file
> 
> 	==> See this mask.h header for more extensive mask documentation <==

Paul,
	2 small changes to include/linux/mask.h:

1) Change #ifndef _ASM_GENERIC_MASK_H to #ifnded __LINUX_MASK_H since
mask.h resides in include/linux/ not include/asm-generic/.

2) In #define mask_complement(), the "nbits" argument to
bitmap_complement wasn't wrapped in parens.

Cheers!

-Matt

[-- Attachment #2: mask_h-mcd.patch --]
[-- Type: text/x-patch, Size: 886 bytes --]

diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.4-pj_nodemask/include/linux/mask.h linux-2.6.4-mask_h-mcd/include/linux/mask.h
--- linux-2.6.4-pj_nodemask/include/linux/mask.h	Tue Mar 30 17:04:27 2004
+++ linux-2.6.4-mask_h-mcd/include/linux/mask.h	Wed Mar 31 15:59:36 2004
@@ -1,5 +1,5 @@
-#ifndef _ASM_GENERIC_MASK_H
-#define _ASM_GENERIC_MASK_H
+#ifndef __LINUX_MASK_H
+#define __LINUX_MASK_H
 
 /*
  * include/linux/mask.h
@@ -273,7 +273,7 @@ do {									\
 } while(0)
 
 #define mask_complement(dst, src, nbits)				\
-	bitmap_complement((dst)._m, (src)._m, nbits)
+	bitmap_complement((dst)._m, (src)._m, (nbits))
 
 #define mask_equal(mask1, mask2)					\
 ({									\
@@ -369,4 +369,4 @@ do {									\
 #define mask_parse(ubuf, ulen, mask, nbits)				\
 	bitmap_parse((ubuf), (ulen), ((mask)._m), (nbits))
 
-#endif /* _ASM_GENERIC_MASK_H */
+#endif /* __LINUX_MASK_H */