From: Rusty Russell <rusty@rustcorp.com.au>
To: Tom Rini <trini@kernel.crashing.org>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [patch 1/22] Add __early_param for all arches
Date: Thu, 01 Apr 2004 12:56:45 +1000 [thread overview]
Message-ID: <1080788204.32535.122.camel@bach> (raw)
In-Reply-To: <20040401022406.GC21709@smtp.west.cox.net>
On Thu, 2004-04-01 at 12:24, Tom Rini wrote:
> > > > +/* Arch code calls this early on. */
> > > > +void __init parse_early_options(const char *saved_command_line)
> > > > +{
> > > > + static char __initdata command_line[COMMAND_LINE_SIZE];
> > > > + strcpy(command_line, saved_command_line);
> memcpy(src, src, size) isn't good, is it? On i386 we start out with the
> commandline in saved_command_line. Everyone else I believe has a local
> var we point cmdline_p at, which gets copied into saved_command_line.
Read again. Not accessing global vars at all: it's a (probably badly
named) parameter.
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
prev parent reply other threads:[~2004-04-01 2:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-24 23:57 [patch 1/22] Add __early_param for all arches trini
2004-03-25 3:55 ` Andrew Morton
2004-03-26 11:29 ` David Woodhouse
2004-03-26 21:03 ` Russell King
2004-03-26 21:15 ` David Woodhouse
2004-03-31 4:23 ` Rusty Russell
2004-03-31 16:13 ` Tom Rini
2004-04-01 1:51 ` Rusty Russell
2004-04-01 2:24 ` Tom Rini
2004-04-01 2:56 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1080788204.32535.122.camel@bach \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox