From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F5642BFC7B for ; Mon, 2 Mar 2026 11:15:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772450128; cv=none; b=D51ddMNWylj+ZsIyargrrITLuKyy0VaoHtBzND+J1rIO8yOBXfhtLCbOpphpOLR8OdLN1jRZHtc+n5bBpSieSHceZFfPAuFiGtyjx6WG5sYfnYO0Ijw4/l9dchFuCZJ3I5+wiRP0oFF4tR4iMdHPKXYCugoSMFFSluIV1VCLwy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772450128; c=relaxed/simple; bh=afrxVChot/iSIeerO75r01XyNSEkPt+dr6VuvhJ7WU8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CYNXf106yO2i+z1Nn0+TCZyKXBSMq0TwXOt7he7AIRxLUazqmQ1UdyvHwTmLVI3JYG59cfWL0SWdtB9Omkpqw7jBtYQZwv0/2DyHLGlj4pkeMta/4kUSxltG3Gm/PfS+YduDz/wyWik5ajomsadlfSxPvSdDhMqQ3qz9BdxPLLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=x0hZM80V; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="x0hZM80V" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=iLvqjthXVt11PUiR+2pEETyDFUm0nnjjHpo7sYg/Wno=; b=x0hZM80VP6/tp3UVzvoL+YWdgO dn2Zc2wB5cWxH974yqdNggaAM5hmS++oibjG7+eMa3YxPTwPKbSQ0QJ8U5Z9FTdEpk3csK7CmwXci QehIN5RgoOvZpfYJO5He3zufgntORITaduaQTxbyD1pL2poGY/EqxL1eslB7B8E8LVvWLcN6P/r4Y UmiJCLdX7Y+FOktTL8zfuRKytZDWO4UMXNni5IcmcHcijBKcLQSHZwNt2mJeQpYaF1/RECrKLo534 gWIa3fTJgJ25WktTNMzOxTEMeqdAhp4jEWyisRBc6aGPC+kpMfVQeayAy+8B6ViSNdQ2YsQ1dnnxO k+pNTdsA==; From: Heiko Stuebner To: Srinivas Kandagatla , Felix Gu Cc: linux-kernel@vger.kernel.org, Felix Gu Subject: Re: [PATCH] nvmem: qnap-mcu-eeprom: Fix struct assignments using commas instead of semicolons Date: Mon, 02 Mar 2026 12:15:23 +0100 Message-ID: <10809879.nUPlyArG6x@phil> In-Reply-To: <20260301-qnap-v1-1-8131c9b2d118@gmail.com> References: <20260301-qnap-v1-1-8131c9b2d118@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Am Sonntag, 1. M=C3=A4rz 2026, 10:51:16 Mitteleurop=C3=A4ische Normalzeit s= chrieb Felix Gu: > The nvcfg struct member assignments were incorrectly using commas instead > of semicolons. >=20 > Signed-off-by: Felix Gu Reviewed-by: Heiko Stuebner I wonder how I managed to make that mistake :-) Thanks for noticing Heiko > --- > drivers/nvmem/qnap-mcu-eeprom.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/nvmem/qnap-mcu-eeprom.c b/drivers/nvmem/qnap-mcu-eep= rom.c > index 0b919895b3b2..07bdaa2a33fa 100644 > --- a/drivers/nvmem/qnap-mcu-eeprom.c > +++ b/drivers/nvmem/qnap-mcu-eeprom.c > @@ -86,10 +86,10 @@ static int qnap_mcu_eeprom_probe(struct platform_devi= ce *pdev) > nvcfg.read_only =3D true; > nvcfg.root_only =3D false; > nvcfg.reg_read =3D qnap_mcu_eeprom_read; > - nvcfg.size =3D QNAP_MCU_EEPROM_SIZE, > - nvcfg.word_size =3D 1, > - nvcfg.stride =3D 1, > - nvcfg.priv =3D mcu, > + nvcfg.size =3D QNAP_MCU_EEPROM_SIZE; > + nvcfg.word_size =3D 1; > + nvcfg.stride =3D 1; > + nvcfg.priv =3D mcu; > =20 > ndev =3D devm_nvmem_register(&pdev->dev, &nvcfg); > if (IS_ERR(ndev)) >=20 > --- > base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31 > change-id: 20260301-qnap-f91e2ca99aab >=20 > Best regards, >=20