From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261987AbUDNXkq (ORCPT ); Wed, 14 Apr 2004 19:40:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262063AbUDNXid (ORCPT ); Wed, 14 Apr 2004 19:38:33 -0400 Received: from mail.kroah.org ([65.200.24.183]:51615 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S261987AbUDNWZN convert rfc822-to-8bit (ORCPT ); Wed, 14 Apr 2004 18:25:13 -0400 Subject: Re: [PATCH] I2C update for 2.6.5 In-Reply-To: <10819814522020@kroah.com> X-Mailer: gregkh_patchbomb Date: Wed, 14 Apr 2004 15:24:12 -0700 Message-Id: <10819814522824@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com Content-Transfer-Encoding: 7BIT From: Greg KH Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org ChangeSet 1.1643.36.21, 2004/04/09 12:06:02-07:00, greg@kroah.com [PATCH] I2C: minor bugfixes for the pcf8591.c driver and formatting cleanups. drivers/i2c/chips/pcf8591.c | 10 ++++------ 1 files changed, 4 insertions(+), 6 deletions(-) diff -Nru a/drivers/i2c/chips/pcf8591.c b/drivers/i2c/chips/pcf8591.c --- a/drivers/i2c/chips/pcf8591.c Wed Apr 14 15:13:11 2004 +++ b/drivers/i2c/chips/pcf8591.c Wed Apr 14 15:13:11 2004 @@ -125,8 +125,7 @@ unsigned int value; struct i2c_client *client = to_i2c_client(dev); struct pcf8591_data *data = i2c_get_clientdata(client); - if ((value = (simple_strtoul(buf, NULL, 10) + 5) / 10) <= 255); - { + if ((value = (simple_strtoul(buf, NULL, 10) + 5) / 10) <= 255) { data->aout = value; i2c_smbus_write_byte_data(client, data->control, data->aout); } @@ -235,9 +234,9 @@ /* OK, this is not exactly good programming practice, usually. But it is very code-efficient in this case. */ - exit_kfree: +exit_kfree: kfree(new_client); - exit: +exit: return err; } @@ -277,8 +276,7 @@ down(&data->update_lock); - if ((data->control & PCF8591_CONTROL_AICH_MASK) != channel) - { + if ((data->control & PCF8591_CONTROL_AICH_MASK) != channel) { data->control = (data->control & ~PCF8591_CONTROL_AICH_MASK) | channel; i2c_smbus_write_byte(client, data->control);