From: 함명주 <myungjoo.ham@samsung.com>
To: Axel Lin <axel.lin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "Anton Vorontsov" <cbouatmailru@gmail.com>,
박경민 <kyungmin.park@samsung.com>, 김동근 <dg77.kim@samsung.com>
Subject: Re: [PATCH] power_supply: Fix modalias for charger-manager
Date: Wed, 11 Jan 2012 11:23:17 +0000 (GMT) [thread overview]
Message-ID: <10819991.146571326280997005.JavaMail.weblogic@epml24> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1550 bytes --]
Written by Axel Lin<axel.lin@gmail.com>
> Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform
> modalias is prefixed with "platform:".
> Current code has the id_table, thus add MODULE_DEVICE_TABLE will
> automatically setup the modalias.
>
> Also make charger_manager_id static as it is only used in this driver.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Thanks.
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> ---
> drivers/power/charger-manager.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c
> index 0378d01..88fd971 100644
> --- a/drivers/power/charger-manager.c
> +++ b/drivers/power/charger-manager.c
> @@ -974,10 +974,11 @@ static int __devexit charger_manager_remove(struct platform_device *pdev)
> return 0;
> }
>
> -const struct platform_device_id charger_manager_id[] = {
> +static const struct platform_device_id charger_manager_id[] = {
> { "charger-manager", 0 },
> { },
> };
> +MODULE_DEVICE_TABLE(platform, charger_manager_id);
>
> static int cm_suspend_prepare(struct device *dev)
> {
> @@ -1069,4 +1070,3 @@ module_exit(charger_manager_cleanup);
> MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham@samsung.com>");
> MODULE_DESCRIPTION("Charger Manager");
> MODULE_LICENSE("GPL");
> -MODULE_ALIAS("charger-manager");
> --
> 1.7.5.4
>
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next reply other threads:[~2012-01-11 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 11:23 함명주 [this message]
2012-02-01 17:40 ` [PATCH] power_supply: Fix modalias for charger-manager Anton Vorontsov
-- strict thread matches above, loose matches on Subject: below --
2012-01-11 9:19 Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10819991.146571326280997005.JavaMail.weblogic@epml24 \
--to=myungjoo.ham@samsung.com \
--cc=axel.lin@gmail.com \
--cc=cbouatmailru@gmail.com \
--cc=dg77.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).