Re: [RFC] fix sysfs symlinks

Greg KH
2004-04-20T16:23:52Z

On Sat, Apr 17, 2004 at 09:22:06AM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote:
> On Sat, Apr 17, 2004 at 09:07:12AM +0100, Russell King wrote:
> > What about other bus types? Do I really need to teach userspace about
> > the relationships between all the various bus types we have on ARM and
> > how to work out what these relationships are by guessing?
> >
> > Please. The symlinks are necessary and they are the sole source of
> > the relationship information.
>
> In which case you want them to be associated with target, not the current
> pathname of target. And no, I don't buy the "so far all renames happen *here*
> and all symlinks are pointing *there*, so we don't care" - that won't last.
>
> When do we have a legitimate reason for dangling symlinks in sysfs, anyway?

Ok, in thinking about it some more, we don't. And I don't have a
problem with grabbing the reference to the target anymore either (after
looking over the code). So no more objections from me about this :)

thanks,

greg k-h