From: Rusty Russell <rusty@rustcorp.com.au>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Linus Torvalds <torvalds@osdl.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix unix module
Date: Sun, 18 Apr 2004 20:05:45 +1000 [thread overview]
Message-ID: <1082282744.15014.33.camel@bach> (raw)
In-Reply-To: <20040418090157.B4239@flint.arm.linux.org.uk>
On Sun, 2004-04-18 at 18:01, Russell King wrote:
> On Sun, Apr 18, 2004 at 03:32:42PM +1000, Rusty Russell wrote:
> > The compiler #define's unix to 1: we use -DKBUILD_MODNAME=unix. We
> > used to #undef unix at the top of af_unix.c, but now the name is
> > inserted by modpost, that doesn't help.
>
> Do we depend on this preprocessor symbol anywhere? If not, adding
> -Uunix to the global CFLAGS would prevent future "accidents".
I don't really mind which way it's done, but this was the direct
translation of the previous fix, so required less testing.
Hopefully noone will ever call their module "linux", "i386" or
"__OPTIMIZE__" 8)
Cheers,
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
prev parent reply other threads:[~2004-04-18 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-18 5:32 [PATCH] Fix unix module Rusty Russell
2004-04-18 8:01 ` Russell King
2004-04-18 10:05 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1082282744.15014.33.camel@bach \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox