From: Chris Mason <mason@suse.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] lockfs - vfs bits
Date: Mon, 19 Apr 2004 09:43:08 -0400 [thread overview]
Message-ID: <1082382187.27614.1491.camel@watt.suse.com> (raw)
In-Reply-To: <20040417163007.67d23c10.akpm@osdl.org>
On Sat, 2004-04-17 at 19:30, Andrew Morton wrote:
> Christoph Hellwig <hch@lst.de> wrote:
> >
> > These are the generic lockfs bits. Basically it takes the XFS freezing
> > statemachine into the VFS. It's all behind the kernel-doc documented
> > freeze_bdev and thaw_bdev interfaces.
>
> Do we expect to see snapshotting patches for other filesystems arise as a
> result of this?
Reiserfs needs this one liner:
reiserfs_write_super_lockfs() is supposed to wait for the transaction
to commit.
Index: linux.t/fs/reiserfs/super.c
===================================================================
--- linux.t.orig/fs/reiserfs/super.c 2004-04-01 08:54:54.000000000 -0500
+++ linux.t/fs/reiserfs/super.c 2004-04-01 09:08:45.000000000 -0500
@@ -88,7 +88,7 @@ static void reiserfs_write_super_lockfs
reiserfs_prepare_for_journal(s, SB_BUFFER_WITH_SB(s), 1);
journal_mark_dirty(&th, s, SB_BUFFER_WITH_SB (s));
reiserfs_block_writes(&th) ;
- journal_end(&th, s, 1) ;
+ journal_end_sync(&th, s, 1) ;
}
s->s_dirt = 0;
reiserfs_write_unlock(s);
prev parent reply other threads:[~2004-04-19 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-17 22:06 [PATCH 1/3] lockfs - vfs bits Christoph Hellwig
2004-04-17 23:30 ` Andrew Morton
2004-04-18 8:17 ` Christoph Hellwig
2004-04-19 13:43 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1082382187.27614.1491.camel@watt.suse.com \
--to=mason@suse.com \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox