* 2.6.5, loop_set_fd()...
@ 2004-04-21 7:51 Yury Umanets
0 siblings, 0 replies; only message in thread
From: Yury Umanets @ 2004-04-21 7:51 UTC (permalink / raw)
To: Linux Kernel ML; +Cc: akpm
Hello all,
I have found small inconsistency in loop_set_fd(). It checks if
->sendfile() is implemented for passed block device file. But in fact,
loop back device driver never calls it. It uses ->sendfile() from
backing store file. See patch.
--- linux-2.6.5/drivers/block/loop.c.orig 2004-04-04
06:37:23.000000000 +0300
+++ linux-2.6.5/drivers/block/loop.c 2004-04-21 10:34:39.066501968
+0300
@@ -646,7 +646,7 @@ static int loop_set_fd(struct loop_devic
* If we can't read - sorry. If we only can't write -
well,
* it's going to be read-only.
*/
- if (!lo_file->f_op->sendfile)
+ if (!file->f_op->sendfile)
goto out_putf;
if (!aops->prepare_write || !aops->commit_write)
Thanks.
--
umka
--
umka
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-04-21 7:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-21 7:51 2.6.5, loop_set_fd() Yury Umanets
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox