From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Brenden Matthews <brenden@rty.ca>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Si3112 S-ATA bug preventing use of udma5.
Date: Sat, 24 Apr 2004 11:44:06 +1000 [thread overview]
Message-ID: <1082771045.10727.46.camel@gaston> (raw)
In-Reply-To: <42822.68.144.162.3.1082757748.squirrel@webmail.rty.ca>
> Incase the link is down/broken, to fix the bug change line 269 of
> drivers/ide/pci/siimage.c from:
>
> u32 speedt = 0;
>
> to:
> u16 speedt = 0;
> The crux of the problem is that the first arguent to OUTW (out WORD)
> was a doubleword. The arguments were getting all screwed up on the stack.
> The lower order 16-bit were being used in the second argument of OUTW,
> and the upper order word was being used as the whole first argument,
> which was always 0000. So basically the on-disk controller was being
> programmed with erroneous settings. This fixes it and SATA on the SiI3112
> is now good on Linux. Apply this fix to linux/drivers/ide/pci/siimage.c
> and recompile your Kernel for SATA love.
Hrm... that's strange. I'd tend to think it's a bogus definition
of outw on this architecture (x86 ?) instead. an u32 should be casted
down to u16 without problem.
Ben.
next prev parent reply other threads:[~2004-04-24 1:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-23 22:02 Si3112 S-ATA bug preventing use of udma5 Brenden Matthews
2004-04-24 1:44 ` Benjamin Herrenschmidt [this message]
2004-04-24 2:30 ` Roland Dreier
2004-04-24 4:31 ` Benjamin Herrenschmidt
2004-04-24 19:35 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1082771045.10727.46.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=brenden@rty.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox