From: Andreas Gruenbacher <agruen@suse.de>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/11] sunrpc-enosys-when-unavail
Date: Tue, 27 Apr 2004 15:38:07 +0200 [thread overview]
Message-ID: <1083073087.19655.9.camel@winden.suse.de> (raw)
In-Reply-To: <1083011614.15282.19.camel@lade.trondhjem.org>
Hello,
net/sunrpc/svc.c has a similar check already to prevent syslog flooding
for such common error conditions:
[] #ifdef RPC_PARANOIA
[] if (prog != 100227 || progp->pg_prog != 100003)
[] printk("svc: unknown program %d (me %d)\n", prog, progp->pg_prog);
[] /* else it is just a Solaris client seeing if ACLs are supported */
[] #endif
We could also get rid of the printk's in net/sunrpc/clnt.c -- your/Neil's call.
On Mon, 2004-04-26 at 22:33, Trond Myklebust wrote:
> On Mon, 2004-04-26 at 06:28, Andreas Gruenbacher wrote:
> > Differentiate between program/procedure not available and other errors
> >
>
> Sorry. This one is unacceptable. I will NOT have program numbers hard
> coded into sunrpc. There should be no reason to do this at all...
>
> Cheers,
> Trond
--
Andreas Gruenbacher <agruen@suse.de>
SUSE Labs, SUSE LINUX AG
prev parent reply other threads:[~2004-04-27 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-26 10:28 [PATCH 1/11] sunrpc-enosys-when-unavail Andreas Gruenbacher
2004-04-26 20:33 ` Trond Myklebust
2004-04-27 13:38 ` Andreas Gruenbacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1083073087.19655.9.camel@winden.suse.de \
--to=agruen@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox