From: Michael Brown <Michael_E_Brown@Dell.com>
To: Greg KH <greg@kroah.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, matt_domsch@dell.com
Subject: Re: [BK PATCH] add SMBIOS tables to sysfs
Date: Tue, 27 Apr 2004 22:55:52 -0500 [thread overview]
Message-ID: <1083124552.1198.2835.camel@debian> (raw)
In-Reply-To: <20040428033020.GA14078@kroah.com>
On Tue, 2004-04-27 at 22:30, Greg KH wrote:
> > + snprintf(sdev->kobj.name, 7, "smbios" );
>
> Try using kobject_set_name() instead, it will do the proper thing if the
> string is bigger than the base kobj.name field.
Looks like this API was added in Aug03. A quick grep through the tree
shows only <10 users. Are there patches pending to convert others, or
are you just having new stuff do this? I know of at least one sysfs
driver (edd) that uses snprintf() that could be converted. I'll send an
updated patch shortly for smbios.c, just curious.
--
Michael
next prev parent reply other threads:[~2004-04-28 3:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-28 2:27 [BK PATCH] add SMBIOS tables to sysfs Michael Brown
2004-04-28 3:30 ` Greg KH
2004-04-28 3:38 ` Michael Brown
2004-04-28 16:50 ` Greg KH
2004-04-28 3:55 ` Michael Brown [this message]
2004-04-28 16:51 ` Greg KH
2004-04-28 4:41 ` [BK PATCH] add SMBIOS tables to sysfs -- UPDATED Michael Brown
-- strict thread matches above, loose matches on Subject: below --
2004-04-28 17:18 [BK PATCH] add SMBIOS tables to sysfs Michael_E_Brown
2004-04-28 17:36 ` Greg KH
2004-04-28 17:37 Michael_E_Brown
2004-04-28 17:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1083124552.1198.2835.camel@debian \
--to=michael_e_brown@dell.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt_domsch@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox