Re: [BK PATCH] add SMBIOS tables to sysfs

Greg KH
2004-04-28T19:38:44Z

On Wed, Apr 28, 2004 at 12:37:19PM -0500, Michael_E_Brown@Dell.com wrote:
> Looks good. You can go ahead and add it to your tree.

Ok, will do, thanks for testing.

> I do have one question, though. Here:
>
> > +static struct kobj_type ktype_smbios = {
> > + .sysfs_ops = &smbios_attr_ops,
> > + .default_attrs = def_attrs,
> > + /* statically allocated, no release method necessary */
> > +};
>
> I have no .release method because I have not kmalloc'ed any
> instances of this struct. Do I need to re-add a release
> method here?

No, you are ok here. Static kobj_type structures are ok for 2.6. For
2.7 we will probably fix up all of this properly, we've learned a lot in
the past few years :)

thanks,

greg k-h