Re: [BK PATCH] add SMBIOS tables to sysfs

Greg KH
2004-04-28T19:14:29Z

On Wed, Apr 28, 2004 at 12:18:21PM -0500, Michael_E_Brown@Dell.com wrote:
> > -----Original Message-----
> > From: Greg KH [mailto:greg@kroah.com]
> >
> > Ok, here are 2 patches. The first small one is on top of your latest
> > version. It gets rid of the extra subdirectory, and removes the
> > unneeded kobject from your static structure (NEVER USE A KOBJECT IN A
> > STATIC STRUCTURE!!!!)
>
> Ok, thanks for the guidance here. I was not aware of this limitation.

{sigh} I think I need to update the documentation...

> > The secone one is against a clean 2.6.6-rc3 kernel that has
> > your latest
> > version + my changes.
> >
> > If you approve of my changes, I'd be glad to add the driver to my bk
> > trees to have it show up in the next -mm release, and I will
> > push it off
> > to Linus after 2.6.6 is out. Sound ok?
>
> This looks good. I'll do a quick compile/boot check. I would really
> appreciate your help in getting this in. (although I was hoping to get
> it into 2.6.6, I guess it can wait for 2.6.7 :-)

Yes, 2.6.6 is too late, sorry.

Let me know if the patch works for you and then I'll add it to my trees.
It worked for me on my box :)

thanks,

greg k-h