Re: [BK PATCH] add SMBIOS tables to sysfs

Michael Brown
2004-04-28T03:39:40Z

On Tue, 2004-04-27 at 22:30, Greg KH wrote:
> Nice idea and patch. A few minor comments:

Thank you.

>
> > /sys/firmware/smbios/smbios/table_entry_point
> > /sys/firmware/smbios/smbios/table
>
> Why repeat the "smbios" directory? Is this a limitation in the sysfs
> interface right now? Or are you going to put more files in the main
> smbios directory some day?

>From what I could tell (please correct me if I am wrong), you can add
only subsystems to the firmware directory. The first "smbios" is for the
subsystem. Then, you can only add devices to the subsystem. The second
"smbios" is for the device.

I really would like to get rid of one myself, but it was not obvious to
me how to do this. No, I do not plan on adding new objects in there.

>
> > + snprintf(sdev->kobj.name, 7, "smbios" );
>
> Try using kobject_set_name() instead, it will do the proper thing if the
> string is bigger than the base kobj.name field.

Ok, thanks.
Thanks,
Michael