From: Bryan O'Donoghue <bod@kernel.org>
To: "Erikas Bitovtas" <xerikasxx@gmail.com>,
"Vikash Garodia" <vikash.garodia@oss.qualcomm.com>,
"Dikshita Agarwal" <dikshita.agarwal@oss.qualcomm.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"André Apitzsch" <git@apitzsch.eu>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Brian Masney" <bmasney@redhat.com>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v4 3/9] media: qcom: venus: Add msm8939 resource struct
Date: Wed, 6 May 2026 00:33:39 +0100 [thread overview]
Message-ID: <108401cb-040a-441c-b463-b69df195378e@kernel.org> (raw)
In-Reply-To: <20260506-msm8939-venus-rfc-v4-3-994f5eb22acb@gmail.com>
On 05/05/2026 22:44, Erikas Bitovtas wrote:
> + .vcodec_clks = { "core0", "core1" },
> + .vcodec_clks_num = 2,
This smells a bit dodgy to me.
You already have
struct clk *vcodec0_clks[VIDC_VCODEC_CLKS_NUM_MAX];
struct clk *vcodec1_clks[VIDC_VCODEC_CLKS_NUM_MAX];
so why add vcodec_clks and put core0 and core1 into a new array.
vcodec0_clks and vcodec1_clks seem like a very natural place for core0
and core1 clocks to live ?
---
bod
next prev parent reply other threads:[~2026-05-05 23:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 21:44 [PATCH v4 0/9] media: qcom: venus: add MSM8939 support Erikas Bitovtas
2026-05-05 21:44 ` [PATCH v4 1/9] media: dt-bindings: venus: Add qcom,msm8939 schema Erikas Bitovtas
2026-05-05 23:26 ` Bryan O'Donoghue
2026-05-06 7:33 ` Krzysztof Kozlowski
2026-05-05 21:44 ` [PATCH v4 2/9] media: qcom: venus: add common clocks used by both vdec and venc Erikas Bitovtas
2026-05-06 7:37 ` Krzysztof Kozlowski
2026-05-05 21:44 ` [PATCH v4 3/9] media: qcom: venus: Add msm8939 resource struct Erikas Bitovtas
2026-05-05 23:33 ` Bryan O'Donoghue [this message]
2026-05-05 21:44 ` [PATCH v4 4/9] arm64: dts: qcom: msm8939: Add venus node Erikas Bitovtas
2026-05-05 21:44 ` [PATCH v4 5/9] arm64: dts: qcom: msm8939-longcheer-l9100: Enable " Erikas Bitovtas
2026-05-05 21:44 ` [PATCH v4 6/9] arm64: dts: qcom: msm8939-asus-z00t: add Venus Erikas Bitovtas
2026-05-05 21:44 ` [PATCH v4 7/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled Erikas Bitovtas
2026-05-05 21:44 ` [PATCH v4 8/9] media: qcom: venus: add power domain enable logic for Venus cores Erikas Bitovtas
2026-05-05 21:44 ` [PATCH v4 9/9] media: qcom: venus: Enable HEVC decoding for MSM8939 Erikas Bitovtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=108401cb-040a-441c-b463-b69df195378e@kernel.org \
--to=bod@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=git@apitzsch.eu \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vikash.garodia@oss.qualcomm.com \
--cc=xerikasxx@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox