public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <len.brown@intel.com>
To: Bob Gill <gillb4@telusplanet.net>
Cc: Alex Riesen <fork0@users.sourceforge.net>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: hdc: lost interrupt ide-cd: cmd 0x3 timed out ...
Date: 09 May 2004 23:27:03 -0400	[thread overview]
Message-ID: <1084159623.12352.71.camel@dhcppc4> (raw)
In-Reply-To: <A6974D8E5F98D511BB910002A50A6647615FAF0B@hdsmsx403.hd.intel.com>

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

On Sun, 2004-05-09 at 22:16, Brown, Len wrote:
> ACPI: PCI Interrupt Link [LNKB] (IRQs 3 4 5 6 7 10 11 12 14 15) *9
...
> Didn't see it in your .JPG dmesg, but I expect this was there:
> 
> ACPI: PCI Interrupt Link [LNKB] enabled at IRQ 15
> 
> and probably that set IRQ15 to level/low which killed IDE.
> 
> Please try the attached patch which disables the sanity
> check above.
> 
> Also might be interesting to see what happens on this system
> if it is booted (without the patch) with "acpi_irq_balance"

Better yet, here's a proposd fix.  Please give it a whirl.

The curve ball was that "illegal" IRQ9.
Its "illegalness" caused us to grab a new IRQ off the possible list,
but since it wasn't zero, we didn't scrub the new IRQ with our
usual heuristics for selecting ISA range IRQs.

I expect this will assign sound to IRQ10 or IRQ11.

thanks,
-Len


[-- Attachment #2: pci_link.patch --]
[-- Type: text/plain, Size: 1301 bytes --]

===== drivers/acpi/pci_link.c 1.28 vs edited =====
--- 1.28/drivers/acpi/pci_link.c	Thu May  6 16:03:17 2004
+++ edited/drivers/acpi/pci_link.c	Sun May  9 23:16:48 2004
@@ -478,7 +478,7 @@
 	PIRQ_PENALTY_PCI_AVAILABLE,	/* IRQ9  PCI, often acpi */
 	PIRQ_PENALTY_PCI_AVAILABLE,	/* IRQ10 PCI */
 	PIRQ_PENALTY_PCI_AVAILABLE,	/* IRQ11 PCI */
-	PIRQ_PENALTY_ISA_TYPICAL,	/* IRQ12 mouse */
+	PIRQ_PENALTY_ISA_USED,	/* IRQ12 mouse */
 	PIRQ_PENALTY_ISA_USED,	/* IRQ13 fpe, sometimes */
 	PIRQ_PENALTY_ISA_USED,	/* IRQ14 ide0 */
 	PIRQ_PENALTY_ISA_USED,	/* IRQ15 ide1 */
@@ -545,17 +545,23 @@
 		if (link->irq.active == link->irq.possible[i])
 			break;
 	}
+	/*
+	 * forget active IRQ that is not in possible list
+	 */
+	if (i == link->irq.possible_count) {
+		if (acpi_strict)
+			printk(KERN_WARNING PREFIX "_CRS %d not found"
+				" in _PRS\n", link->irq.active);
+		link->irq.active = 0;
+	}
 
 	/*
 	 * if active found, use it; else pick entry from end of possible list.
 	 */
-	if (i != link->irq.possible_count) {
+	if (link->irq.active) {
 		irq = link->irq.active;
 	} else {
 		irq = link->irq.possible[link->irq.possible_count - 1];
-		if (acpi_strict)
-			printk(KERN_WARNING PREFIX "_CRS %d not found"
-				" in _PRS\n", link->irq.active);
 	}
 
 	if (acpi_irq_balance || !link->irq.active) {

       reply	other threads:[~2004-05-10  3:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <A6974D8E5F98D511BB910002A50A6647615FAF0B@hdsmsx403.hd.intel.com>
2004-05-10  3:27 ` Len Brown [this message]
2004-05-10 11:18   ` hdc: lost interrupt ide-cd: cmd 0x3 timed out Alex Riesen
     [not found] <A6974D8E5F98D511BB910002A50A6647615FAE21@hdsmsx403.hd.intel.com>
2004-05-09  2:56 ` Len Brown
2004-05-09  9:31   ` Alex Riesen
     [not found]   ` <1084135217.4430.141.camel@localhost.localdomain>
2004-05-10  2:16     ` Len Brown
2004-05-10  7:17   ` Alex Riesen
2004-05-10  8:08   ` Alex Riesen
2004-05-06 23:07 hdc: lost interrupt ide-cd: cmd 0x3 timed out with 2.6.6-rc3-bk8 Bob Gill
2004-05-07 11:07 ` hdc: lost interrupt ide-cd: cmd 0x3 timed out Alex Riesen
2004-05-07 19:41   ` Bob Gill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1084159623.12352.71.camel@dhcppc4 \
    --to=len.brown@intel.com \
    --cc=fork0@users.sourceforge.net \
    --cc=gillb4@telusplanet.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox