public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Sebastian Schmidt <yath@yath.eu.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hci-usb bugfix
Date: Mon, 10 May 2004 18:19:34 +0200	[thread overview]
Message-ID: <1084205974.9639.16.camel@pegasus> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0405101211350.669-100000@ida.rowland.org>

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

Hi Alan,

> It looks like the problem is that hci_usb_disconnect() is trying to do too 
> much.  When called for the SCO interface it should simply return.

I came to the same conclusion, but I used the attached patch.

> Does this patch improve the situation?

Not tested ;)

Regards

Marcel


[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 530 bytes --]

===== drivers/bluetooth/hci_usb.c 1.49 vs edited =====
--- 1.49/drivers/bluetooth/hci_usb.c	Sat Apr 17 00:23:48 2004
+++ edited/drivers/bluetooth/hci_usb.c	Mon May 10 12:03:05 2004
@@ -976,11 +971,13 @@
 static void hci_usb_disconnect(struct usb_interface *intf)
 {
 	struct hci_usb *husb = usb_get_intfdata(intf);
-	struct hci_dev *hdev = husb->hdev;
+	struct hci_dev *hdev;
 
-	if (!husb)
+	if (!husb || intf == husb->isoc_iface)
 		return;
+
 	usb_set_intfdata(intf, NULL);
+	hdev = husb->hdev;
 
 	BT_DBG("%s", hdev->name);
 

  reply	other threads:[~2004-05-10 16:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-09 19:47 [PATCH] hci-usb bugfix Sebastian Schmidt
2004-05-09 20:39 ` Marcel Holtmann
2004-05-10 16:13   ` Alan Stern
2004-05-10 16:19     ` Marcel Holtmann [this message]
2004-05-10 16:36       ` Oliver Neukum
2004-05-10 16:52         ` Marcel Holtmann
2004-05-10 19:15           ` Oliver Neukum
2004-05-10 19:39             ` Marcel Holtmann
2004-05-10 20:38               ` Oliver Neukum
2004-05-10 20:58                 ` Marcel Holtmann
2004-05-10 17:19       ` Alan Stern
2004-05-10 17:27         ` Marcel Holtmann
2004-05-10 17:52           ` Alan Stern
2004-05-10 18:07             ` Marcel Holtmann
2004-05-11 14:59               ` Alan Stern
2004-05-12 13:13                 ` Marcel Holtmann
2004-05-09 22:37 ` Soeren Sonnenburg
2004-05-10 10:40   ` Marcel Holtmann
2004-05-11  7:30     ` Soeren Sonnenburg
2004-05-12 13:15       ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1084205974.9639.16.camel@pegasus \
    --to=marcel@holtmann.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=yath@yath.eu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox