[PATCH] befs i_flags thinko

[PATCH] befs i_flags thinko

[Will Dyson]

This was caught by Jörn Engel <joern@wohnheim.fh-wedel.de> some time
ago. It is obviously correct. My public apologies to Jörn for delaying
his patch.


 linuxvfs.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

 
--- linux-2.6.4/fs/befs/linuxvfs.c~ext23_inode_flags    2004-03-21 17:43:58.000000000 +0100
+++ linux-2.6.4/fs/befs/linuxvfs.c      2004-03-24 01:01:11.000000000 +0100
@@ -376,7 +376,7 @@
        befs_ino->i_attribute = fsrun_to_cpu(sb, raw_inode->attributes);
        befs_ino->i_flags = fs32_to_cpu(sb, raw_inode->flags);
 
-       if (S_ISLNK(inode->i_mode) && !(inode->i_flags & BEFS_LONG_SYMLINK)) {
+       if (S_ISLNK(inode->i_mode) && !(befs_ino->i_flags & BEFS_LONG_SYMLINK)){
                inode->i_size = 0;
                inode->i_blocks = befs_sb->block_size / VFS_BLOCK_SIZE;
                strncpy(befs_ino->i_data.symlink, raw_inode->data.symlink,

Re: [PATCH] befs i_flags thinko

[Jörn Engel]

On Fri, 14 May 2004 12:07:28 -0400, Will Dyson wrote:
> 
> This was caught by Jörn Engel <joern@wohnheim.fh-wedel.de> some time
> ago. It is obviously correct. My public apologies to Jörn for delaying
> his patch.

Hey, you just uncovered a race condition, see my mail from 1min ago.
Not sure if I want to fix such a thing, though. ;)

Jörn

-- 
Beware of bugs in the above code; I have only proved it correct, but
not tried it.
-- Donald Knuth

Re: [PATCH] befs i_flags thinko

[Will Dyson]

Jörn Engel wrote:
> On Fri, 14 May 2004 12:07:28 -0400, Will Dyson wrote:
> 
>>This was caught by Jörn Engel <joern@wohnheim.fh-wedel.de> some time
>>ago. It is obviously correct. My public apologies to Jörn for delaying
>>his patch.
> 
> 
> Hey, you just uncovered a race condition, see my mail from 1min ago.
> Not sure if I want to fix such a thing, though. ;)

:)

Heh, your recent mail contains a description. Therefor, that is the one 
that should be used.

-- 
Will Dyson
"Back off man, I'm a scientist!" -Dr. Peter Venkman