From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] I2C update for 2.6.6
Date: Fri, 14 May 2004 16:29:17 -0700 [thread overview]
Message-ID: <10845773573133@kroah.com> (raw)
In-Reply-To: <10845773573392@kroah.com>
ChangeSet 1.1587.15.12, 2004/05/11 13:43:55-07:00, khali@linux-fr.org
[PATCH] I2C: kill duplicate includes in i2c bus drivers
Following a suggestion of Arthur Othieno, here is a trivial patch that
kills duplicate inclusions of config.h in four i2c bus drivers.
At first I was thinking of also removing inclusions of config.h wherever
it doesn't seem to be necessary but Eugene doesn't seem to think it's a
good idea. So I may give it a try later (in 2.7), but for now this
simple patch will be enough.
drivers/i2c/busses/i2c-keywest.c | 1 -
drivers/i2c/busses/i2c-piix4.c | 1 -
drivers/i2c/busses/scx200_acb.c | 1 -
drivers/i2c/busses/scx200_i2c.c | 1 -
4 files changed, 4 deletions(-)
diff -Nru a/drivers/i2c/busses/i2c-keywest.c b/drivers/i2c/busses/i2c-keywest.c
--- a/drivers/i2c/busses/i2c-keywest.c Fri May 14 16:19:27 2004
+++ b/drivers/i2c/busses/i2c-keywest.c Fri May 14 16:19:27 2004
@@ -48,7 +48,6 @@
#include <linux/config.h>
#include <linux/module.h>
-#include <linux/config.h>
#include <linux/kernel.h>
#include <linux/ioport.h>
#include <linux/pci.h>
diff -Nru a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
--- a/drivers/i2c/busses/i2c-piix4.c Fri May 14 16:19:27 2004
+++ b/drivers/i2c/busses/i2c-piix4.c Fri May 14 16:19:27 2004
@@ -31,7 +31,6 @@
#include <linux/config.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
-#include <linux/config.h>
#include <linux/pci.h>
#include <linux/kernel.h>
#include <linux/stddef.h>
diff -Nru a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c
--- a/drivers/i2c/busses/scx200_acb.c Fri May 14 16:19:27 2004
+++ b/drivers/i2c/busses/scx200_acb.c Fri May 14 16:19:27 2004
@@ -25,7 +25,6 @@
*/
#include <linux/config.h>
-#include <linux/config.h>
#include <linux/module.h>
#include <linux/errno.h>
#include <linux/kernel.h>
diff -Nru a/drivers/i2c/busses/scx200_i2c.c b/drivers/i2c/busses/scx200_i2c.c
--- a/drivers/i2c/busses/scx200_i2c.c Fri May 14 16:19:27 2004
+++ b/drivers/i2c/busses/scx200_i2c.c Fri May 14 16:19:27 2004
@@ -22,7 +22,6 @@
*/
#include <linux/config.h>
-#include <linux/config.h>
#include <linux/module.h>
#include <linux/errno.h>
#include <linux/kernel.h>
next prev parent reply other threads:[~2004-05-14 23:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-14 23:27 [BK PATCH] I2C update for 2.6.6 Greg KH
2004-05-14 23:29 ` [PATCH] " Greg KH
2004-05-14 23:29 ` Greg KH
2004-05-14 23:29 ` Greg KH
2004-05-14 23:29 ` Greg KH
2004-05-14 23:29 ` Greg KH
2004-05-14 23:29 ` Greg KH
2004-05-14 23:29 ` Greg KH
2004-05-14 23:29 ` Greg KH
2004-05-14 23:29 ` Greg KH
2004-05-14 23:29 ` Greg KH
2004-05-14 23:29 ` Greg KH
2004-05-14 23:29 ` Greg KH [this message]
2004-05-14 23:29 ` Greg KH
2004-05-14 23:29 ` Greg KH
2004-05-14 23:29 ` Greg KH
2004-05-14 23:29 ` Greg KH
2004-05-14 23:29 ` Greg KH
2004-05-14 23:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10845773573133@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox