Re: Resume enhancement: restore pci config space

[Arjan van de Ven <arjanv@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 741 bytes --]


> int xxx_resume(struct pci_dev *dev)
> {
> 	int err;
> 	if ((err = pci_default_resume(dev)) < 0)
> 		return err;
> 	// ... do h/w specific
> }

well define "h/w specific", just give me an example of a real (alsa?)
driver that would use it (or point me to one) so that I can see if this
is the best API, what the return value should be etc etc 
> 
> 
> but IMO, the jobs of pci_default_suspend/resume() should be applied
> always after/before calling driver's suspend/resume callbacks.

I would be very wary of unconditionally doing the resume thing without
the driver having had a chance to do it's thing. Imo the driver HAS to
be able to override stuff or at least talk to the hw before the generic
resume happens.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]