From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20B0FC4320A for ; Thu, 29 Jul 2021 03:09:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1E2960F9B for ; Thu, 29 Jul 2021 03:09:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233581AbhG2DJW (ORCPT ); Wed, 28 Jul 2021 23:09:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233297AbhG2DJV (ORCPT ); Wed, 28 Jul 2021 23:09:21 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CA03C061757 for ; Wed, 28 Jul 2021 20:09:18 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id f22so4509657qke.10 for ; Wed, 28 Jul 2021 20:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vt-edu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:in-reply-to:references:mime-version :content-transfer-encoding:date:message-id; bh=SdHnd3UxhQxILD5sIY68I8w2CS+2K2nQR0hdwBItcSQ=; b=1fuWuTp0S9vFfzdBLCV3w1xBUH4RYC//+UhbZLlGYzInl7HpKECRExfamgdx9eRolN pXxGhX4yl1vQgiqq79cpBOenFVyx6uEYvqYz2oqAhPuX1kIcBreKvpIlI0irOSjtsjXU 0W6X8Mas7FaprAPVqoVjugg9OX0tHpHbPSRCqMOTMc7NwRWFNP6Po371r05TndavoxN3 7ZOQNrGPvcO+rXPj+GuqhhCfqOQOOxOFjXEvQpB9G5bbJRXCq/6PQEAN5AnFSjrLQ+9e d6lJcFOP0YVNlrp6ii47qjLM0W97tovZ/w2mTmrNJxiMCrEjlo6pv5Usv83bGYFxyMCa 1p7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:content-transfer-encoding:date:message-id; bh=SdHnd3UxhQxILD5sIY68I8w2CS+2K2nQR0hdwBItcSQ=; b=XperK0QTOXbd71v4/DKSmttiGxNUFEEDtTtAY0mnBeMLofyvg8CuJ4CmHRATq2Uijb pKxY+LGIwUwVXhNR9G7MMHJXsRgCkHU3gz0OhIz9Ood5b7qB2tM6dQ6uMM2kMhTe21cm FfxMnu9uoy9ylVHkXqq8c3+RpVvCXSZT7xPzWOoz8GIR/zJ90ACg0nGapprPd6pVCWGB TgM6W55esdWapUAK+/9qTtHndyqDs9xtvZNpewKKCamkt/NSPwZVIvYyGfKWd1xAq1+j PqVQvPWezpule/h28uVt9Dj2dYiKNGAgjqJjOdItxSfGK1OCiB4fztSIjfT8UTICZRaP wbsw== X-Gm-Message-State: AOAM5307ADCR6ykxdu9/oXWWr4dyYxUp0iR6kQG4xCC+Pbe1R+RC6Nok yFwinLxA9xeUNEu+SZMPNnsTlQ== X-Google-Smtp-Source: ABdhPJwDK0qVuMlp6WgaA3Az4Au4QJilqAUMO8ICEJgVOV83q4gFst/vTmoNWJBscKKsVOjnSF/VOA== X-Received: by 2002:a37:6151:: with SMTP id v78mr3152537qkb.9.1627528157390; Wed, 28 Jul 2021 20:09:17 -0700 (PDT) Received: from turing-police ([2601:5c0:c380:d61::359]) by smtp.gmail.com with ESMTPSA id q11sm1011870qkm.56.2021.07.28.20.09.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 20:09:16 -0700 (PDT) Sender: Valdis Kletnieks From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.10.0-pre 07/05/2021 with nmh-1.7+dev To: Ian Pilcher Cc: linux-block@vger.kernel.org, linux-leds@vger.kernel.org, axboe@kernel.dk, pavel@ucw.cz, linux-kernel@vger.kernel.org, kernelnewbies@kernelnewbies.org Subject: Re: [RFC PATCH 1/8] docs: Add block device LED trigger documentation In-Reply-To: <20210729015344.3366750-2-arequipeno@gmail.com> References: <20210729015344.3366750-1-arequipeno@gmail.com> <20210729015344.3366750-2-arequipeno@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1627528155_13589P"; micalg=pgp-sha256; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Wed, 28 Jul 2021 23:09:15 -0400 Message-ID: <108629.1627528155@turing-police> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --==_Exmh_1627528155_13589P Content-Type: text/plain; charset=us-ascii On Wed, 28 Jul 2021 20:53:37 -0500, Ian Pilcher said: > +Create a new block device LED trigger:: > + > + # echo foo > /sys/class/block/led_trigger_new > + > +The name must be unique among all LED triggers (not just block device LED > +triggers). > + > +Create two more:: > + > + # echo bar baz > /sys/class/block/led_trigger_new > + # cat /sys/class/block/led_trigger_list > + baz: 0 > + bar: 0 > + foo: 0 This looks like an abuse of the "one entry one value" rule for sysfs. Perhaps this should be a directory /sys/class/block/defined_triggers/ and separate files under that for foo, bar, and baz? That would probably make reference counting a lot easier as well.... --==_Exmh_1627528155_13589P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Comment: Exmh version 2.9.0 11/07/2018 iQEcBAEBCAAGBQJhAhvbAAoJEI0DS38y7CIctZEH/3Pdfz1JB35y9wFELHDki00R /UC64FJqOqMfASDl0QtxgVV1S3MfGAAqXFlUw1Djb/0/ZcytyZ22f2S0u8JaP9Qx M4Wr0eo5A/BLR7csFwxoxN7lfxDFyEcsKKx+kkZZgfmoqbTLzt46NXTRWrcxJ5p4 rc9KA6hWGz3GYFUj48Maz9VA3hNz3RLcmOy/F1DKHk7nwBrXZ775iKToao4uNNrw Y0NNAAFQYQ8LBZkf5G2hxBakpIA5jY+7arv2dIDO6f+MyDQYKH8gvJEO1vFmiyMM OAufuI4mM8ouhA11rIRqtZZ9acl12CJt/OK8FPifF+ypiFVqbqZHteNbzIvbmY4= =IjcV -----END PGP SIGNATURE----- --==_Exmh_1627528155_13589P--