public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel@daenzer.net>
To: Colin Leroy <colin@colino.net>
Cc: Benjamin <benh@kernel.crashing.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.sf.net
Subject: Re: 2.6.7-rc2: no more AGP?
Date: Fri, 04 Jun 2004 18:21:48 +0200	[thread overview]
Message-ID: <1086366108.4243.117.camel@localhost> (raw)
In-Reply-To: <20040604174818.03a4f795@jack.colino.net>

On Fri, 2004-06-04 at 17:48 +0200, Colin Leroy wrote:
> 
> just a lousy bugreport... I noticed that agpgart doesn't work anymore on
> 2.6.7-rc2. Xorg reports that AGP isn't supported, and dmesg doesn't show
> the
> agpgart: Putting AGP V2 device at 0000:00:0b.0 into 4x mode
> agpgart: Putting AGP V2 device at 0000:00:10.0 into 4x mode
> 
> It only shows
> Linux agpgart interface v0.100 (c) Dave Jones
> agpgart: Detected Apple UniNorth 2 chipset
> agpgart: Maximum main memory to use for agp memory: 565M
> agpgart: configuring for size idx: 4
> agpgart: AGP aperture is 16M @ 0x0
> 
> Using 2.6.6, it works fine. 

Paulus brought this up on IRC, it seems to be a bad DRM merge: The code

#ifndef VMAP_4_ARGS
       if ( dev->agp->cant_use_aperture )
               return -EINVAL;
#endif

in DRM(agp_acquire) should be removed altogether in a 2.6 kernel because
its vmap() takes 4 arguments; however, only the guards seem to have been
removed, which causes this function to erroneously fail if the AGP
aperture can't be directly accessed by the CPU.


-- 
Earthling Michel Dänzer      |     Debian (powerpc), X and DRI developer
Libre software enthusiast    |   http://svcs.affero.net/rm.php?r=daenzer


  parent reply	other threads:[~2004-06-04 16:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-04 15:48 2.6.7-rc2: no more AGP? Colin Leroy
2004-06-04 16:17 ` Benjamin Herrenschmidt
2004-06-05  3:36   ` Paul Mackerras
2004-06-04 16:21 ` Michel Dänzer [this message]
2004-06-04 19:39   ` [PATCH] 2.6.7-rc2: fix agpgart Colin Leroy
2004-06-05  8:23     ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1086366108.4243.117.camel@localhost \
    --to=michel@daenzer.net \
    --cc=benh@kernel.crashing.org \
    --cc=colin@colino.net \
    --cc=dri-devel@lists.sf.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox