From: Chris Mason <mason@suse.com>
To: "Mika Penttilä" <mika.penttila@kolumbus.fi>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] writeback_inodes can race with unmount
Date: Tue, 08 Jun 2004 16:18:47 -0400 [thread overview]
Message-ID: <1086725926.10973.161.camel@watt.suse.com> (raw)
In-Reply-To: <40C61A20.4000906@kolumbus.fi>
On Tue, 2004-06-08 at 15:57, Mika Penttilä wrote:
> Chris Mason wrote:
>
> >There's a small window where the filesystem can be unmounted during
> >writeback_inodes. The end result is the iput done by sync_sb_inodes
> >could be done after the FS put_super and and the super has been removed
> >from all lists.
> >
> >
>
> Why don't we have the same race in the sync() path as well? Moving the
> locking to sync_sb_inodes() itself would fix it also.
In the sync() path we're already taking a read lock on s_umount sem.
Moving the locking into sync_sb_inodes would be tricky, it is sometimes
called with the write lock on s_umount_sem held and sometimes with a
read lock.
-chris
next prev parent reply other threads:[~2004-06-08 20:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-08 19:22 [PATCH] writeback_inodes can race with unmount Chris Mason
2004-06-08 19:57 ` Mika Penttilä
2004-06-08 20:18 ` Chris Mason [this message]
2004-06-08 21:56 ` Andrew Morton
2004-06-09 1:29 ` Chris Mason
2004-06-09 3:22 ` Andrew Morton
2004-06-09 5:24 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1086725926.10973.161.camel@watt.suse.com \
--to=mason@suse.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.penttila@kolumbus.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox