Re: [STACK] >3k call path in reiserfs

Hans Reiser
2004-06-09T17:05:41Z

Chris Mason wrote:

>On Wed, 2004-06-09 at 08:31, Chris Mason wrote:
>
>
>>On Wed, 2004-06-09 at 08:22, Jörn Engel wrote:
>>
>>
>>>reiserfs has some stack-hungry functions as well. Could you put them
>>>on a diet?
>>>
>>>
>>>
>>Yes, we should be able to fix things by getting rid of some of the
>>inlines in a few spots (some funcs are much too large for inlining).
>>I'll send a patch out this morning.
>>
>>
>
>No such luck, the real offender is having tree balance structs on the
>stack. We need to switch to kmalloc for those, which will be mean some
>extra work to make sure we don't schedule at the wrong time.
>
>In other words, not the trivial patch I was hoping for, but I'm cooking
>one up.
>
>-chris
>
>
>
>
>
>
Can you give me some background on whether this is causing real problems
for real users?