Re: ide errors in 7-rc1-mm1 and later

Andrew Morton
2004-06-09T22:04:23Z

Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl> wrote:
>
> Sure, you don't need my ACK, that's obvious - you need it from Linus/Andrew.

But your nack would almost certainly prevent a merge, pending resolution of
whatever the issues are.

>
> ...
>
> BTW are you aware of two (minor?) corner cases of the current implementation?
>
> - you can't have journal on a separate device
> (pre and post flushes will only flush device storing journal not data)

External journals in ext3 aren't really supported - they just happen to
work as a plaything. I haven't tested it in several years, but I believe
people do use it.

That being said, the bug you identify is an ext3 bug. The easiest way for
me to fix it up within ext3 would be to issue some flush command to the
filesystem's disk, wait for that to complete, then write the buffer_ordered
commit block to the journal's disk. That's blkdev_issue_flush(), yes?

> - if you more than > 1 filesystem on the disk (quite likely scenario) it
> can happen that barrier (flush) will fail for sector for file from the
> other fs and later barrier for this other fs will succeed

I don't understand this one.