From: David Howells <dhowells@redhat.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 7/8] FDPIC: Add coredump capability for the ELF-FDPIC binfmt [try #4]
Date: Mon, 10 Jul 2006 14:31:31 +0100 [thread overview]
Message-ID: <10872.1152538291@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <20060710024657.GA255@oleg>
Oleg Nesterov <oleg@tv-sign.ru> wrote:
> Do you see any reason for tasklist_lock here (and in elf_core_dump) ?
>
> do_each_thread() is rcu-safe, and all tasks which use this ->mm must
> sleep in wait_for_completion(&mm->core_done) at this point.
Hmmm... do_each_thread() does not call rcu_read_lock/unlock(), but you may
well be right. What about kernel threads running on another CPU with
active_mm set to this mm (assuming I'm remembering correctly how that works)?
I'm not sure they'd be a problem, though.
It does sound like you've got a valid point, though.
David
next prev parent reply other threads:[~2006-07-10 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 2:46 [PATCH 7/8] FDPIC: Add coredump capability for the ELF-FDPIC binfmt [try #4] Oleg Nesterov
2006-07-10 13:31 ` David Howells [this message]
2006-07-11 17:45 ` Oleg Nesterov
-- strict thread matches above, loose matches on Subject: below --
2006-07-07 11:47 [PATCH 0/8] Fix FRV, ELF-FDPIC and NOMMU stuff " David Howells
2006-07-07 11:47 ` [PATCH 7/8] FDPIC: Add coredump capability for the ELF-FDPIC binfmt " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10872.1152538291@warthog.cambridge.redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox