From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Roland Dreier <roland@topspin.com>
Cc: Andrew Morton <akpm@osdl.org>,
anton@au.ibm.com,
linuxppc64-dev <linuxppc64-dev@lists.linuxppc.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix ppc64 out_be64
Date: Mon, 14 Jun 2004 16:10:05 -0500 [thread overview]
Message-ID: <1087247403.8697.198.camel@gaston> (raw)
In-Reply-To: <52wu2928ej.fsf@topspin.com>
On Mon, 2004-06-14 at 15:26, Roland Dreier wrote:
> Benjamin> Well, I may know ppc asm, but gcc inline asm still
> Benjamin> drives me nuts :)
>
> Speaking of gcc asm, is there a reason why out_le64 (specifically the
> constraints) isn't written in this (simpler) way? It seems to me we
> can just let val be an input, as long as the "&" constraint for tmp
> makes sure it doesn't share the same register. This seems to generate
> the same code for me as the current kernel version, at least with gcc
> 3.4.0/binutils 2.15.
Hrm... and addr too .. well, I'm just paranoid about those constraints,
I never took the time to fully understand how gcc deals with them
and got bitten by them often enough. I'd rather keep the version that
just works at this point ;)
Ben.
prev parent reply other threads:[~2004-06-14 21:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-12 22:00 [PATCH] Fix ppc64 out_be64 Roland Dreier
2004-06-13 15:50 ` Benjamin Herrenschmidt
2004-06-13 16:21 ` Anton Blanchard
2004-06-13 17:08 ` Benjamin Herrenschmidt
2004-06-13 16:48 ` Roland Dreier
2004-06-13 17:11 ` Benjamin Herrenschmidt
2004-06-14 20:26 ` Roland Dreier
2004-06-14 21:10 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1087247403.8697.198.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=anton@au.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
--cc=roland@topspin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox