public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjanv@redhat.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>,
	Linux/m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: page allocation failure. order:0, mode:0x20
Date: Sun, 20 Jun 2004 12:33:11 +0200	[thread overview]
Message-ID: <1087727591.2805.8.camel@laptop.fenrus.com> (raw)
In-Reply-To: <40D565FE.1050903@yahoo.com.au>

[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]

On Sun, 2004-06-20 at 12:25, Nick Piggin wrote:
> > 
> > | # free
> > |              total       used       free     shared    buffers     cached
> > | Mem:         10260       9844        416          0        240       5004
> > | -/+ buffers/cache:       4600       5660
> > | Swap:        33256       3796      29460
> > 
> 
> Not even atomic allocations memory are allowed to consume all memory.
> A small amount is reserved for memory freeing (which sometimes
> requires initial memory allocations).
> 
> The message should be harmless.

Since atomic allocations by definition need to be able to cope with
failure, how about a patch like this to not warn for this common and
legit case?

diff -urNp linux-1130/include/linux/gfp.h
linux-10000/include/linux/gfp.h
--- linux-1130/include/linux/gfp.h
+++ linux-10000/include/linux/gfp.h
@@ -46,7 +46,7 @@ struct vm_area_struct;
                        __GFP_COLD|__GFP_NOWARN|__GFP_REPEAT| \
                       
__GFP_NOFAIL|__GFP_NORETRY|__GFP_NO_GROW|__GFP_COMP)
                                                                                                                   
-#define GFP_ATOMIC     (__GFP_HIGH)
+#define GFP_ATOMIC     (__GFP_HIGH | __GFP_NOWARN)
 #define GFP_NOIO       (__GFP_WAIT)
 #define GFP_NOFS       (__GFP_WAIT | __GFP_IO)
 #define GFP_KERNEL     (__GFP_WAIT | __GFP_IO | __GFP_FS)


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2004-06-20 10:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-20  9:20 page allocation failure. order:0, mode:0x20 Geert Uytterhoeven
2004-06-20 10:25 ` Nick Piggin
2004-06-20 10:31   ` Geert Uytterhoeven
2004-06-20 10:33   ` Arjan van de Ven [this message]
2004-06-20 10:54     ` Nick Piggin
  -- strict thread matches above, loose matches on Subject: below --
2004-03-19 14:08 Naveen Burmi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1087727591.2805.8.camel@laptop.fenrus.com \
    --to=arjanv@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox