From: Chris Mason <mason@suse.com>
To: linux-kernel@vger.kernel.org
Subject: deadlocks caused by ext3/reiser dirty_inode calls during do_mmap_pgoff
Date: Mon, 21 Jun 2004 12:59:14 -0400 [thread overview]
Message-ID: <1087837153.1512.176.camel@watt.suse.com> (raw)
Hello everyone,
do_mmap_pgoff is called with a write lock on mmap_sem, and can trigger
calls to generic_file_mmap, which calls file_accessed to update the
atime on the file.
For reiserfs, this might start a transaction, which might have to wait
for the currently running transaction to finish. It looks like ext3 may
do the same thing, but I'm not 100% sure on that.
If the currently running transaction happens to by running
copy_from_user, like we do during write calls, it might be trying to get
a hold of a read lock on the mmap sem while trying to hand page faults.
This is effectively a lock inversion problem, and deadlocks. There's a
few choices:
1) don't start a transaction during atime updates.
2) don't update the atime until after we drop the mmap_sem.
Anyone have other ideas?
-chris
next reply other threads:[~2004-06-21 16:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-21 16:59 Chris Mason [this message]
2004-06-22 0:13 ` deadlocks caused by ext3/reiser dirty_inode calls during do_mmap_pgoff Andrew Morton
2004-06-22 14:13 ` Chris Mason
2004-06-22 18:57 ` Andrew Morton
2004-06-22 20:32 ` Chris Mason
2004-06-22 14:43 ` Chris Mason
2004-06-22 19:05 ` Andrew Morton
2004-06-22 20:41 ` Chris Mason
2004-06-25 17:59 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1087837153.1512.176.camel@watt.suse.com \
--to=mason@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox