From: "Stephen C. Tweedie" <sct@redhat.com>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: Steven Dake <sdake@mvista.com>, Stian Jordet <liste@jordet.nu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
sct@redhat.logos.cnet, Andrew Morton <akpm@osdl.org>,
Stephen Tweedie <sct@redhat.com>
Subject: Re: [2.4] page->buffers vanished in journal_try_to_free_buffers()
Date: 22 Jun 2004 23:13:29 +0100 [thread overview]
Message-ID: <1087942408.2012.31.camel@sisko.scot.redhat.com> (raw)
In-Reply-To: <20040621155313.GA12559@logos.cnet>
Hi,
On Mon, 2004-06-21 at 16:53, Marcelo Tosatti wrote:
> > The buffer-ring debug patch that you posted looks like the obvious way
> > to dig further into this. If that doesn't get anyway, we can also trap
> > the case where following bh->b_this_page gives us a buffer whose b_page
> > is on a different page.
>
> Fine. Just printing out bh->b_page at debug_page() will allow us to verify that, yes?
For most cases, yes. There are basically three corruption cases ---
b_this_page leads us to an oops, an infinite loop, or a loop including a
bogus page. Trapping the b_this_page ring walks to trap on any bad
b_page would help in the latter two cases, but if we're always getting
the first case, just extending the existing debug patch would be fine.
--Stephen
prev parent reply other threads:[~2004-06-22 22:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-03 18:26 Oopses with both recent 2.4.x kernels and 2.6.x kernels Stian Jordet
2004-02-05 23:51 ` Marcelo Tosatti
2004-03-02 11:03 ` Stian Jordet
2004-03-02 12:31 ` Stian Jordet
2004-03-09 19:22 ` Marcelo Tosatti
2004-03-09 22:28 ` Stian Jordet
2004-06-14 17:07 ` Steven Dake
2004-06-14 18:26 ` Chris Shoemaker
2004-06-15 13:16 ` Marcelo Tosatti
2004-06-15 14:35 ` Stian Jordet
2004-06-15 17:56 ` Steven Dake
2004-06-17 13:16 ` [2.4] page->buffers vanished in journal_try_to_free_buffers() Marcelo Tosatti
2004-06-18 3:08 ` Andrew Morton
2004-06-19 19:48 ` Marcelo Tosatti
2004-06-19 19:50 ` Frank van Maarseveen
2004-06-19 22:17 ` Marcelo Tosatti
2004-06-19 22:44 ` Frank van Maarseveen
2004-06-19 20:04 ` Andrew Morton
2004-06-20 7:56 ` Willy Tarreau
2004-06-21 15:06 ` Stephen C. Tweedie
2004-06-21 15:53 ` Marcelo Tosatti
2004-06-22 22:13 ` Stephen C. Tweedie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1087942408.2012.31.camel@sisko.scot.redhat.com \
--to=sct@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liste@jordet.nu \
--cc=marcelo.tosatti@cyclades.com \
--cc=sct@redhat.logos.cnet \
--cc=sdake@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox