Re: [PATCH 5/6] 2.6.7-mm1, remove unused ASUS K7V-RM DMI quirk

Jeff Garzik
2004-06-23T14:54:33Z

Andrey Panin wrote:
> BROKEN_ACPI_Sx flag doesn't seem to be used anywhere in the kernel,
> so ASUS K7V-RM can be removed.
>
> Signed-off-by: Andrey Panin <pazke@donpac.ru>
>
> arch/i386/kernel/dmi_scan.c | 17 -----------------
> 1 files changed, 17 deletions(-)
>
> diff -urpN -X /usr/share/dontdiff linux-2.6.7-mm1.vanilla/arch/i386/kernel/dmi_scan.c linux-2.6.7-mm1/arch/i386/kernel/dmi_scan.c
> --- linux-2.6.7-mm1.vanilla/arch/i386/kernel/dmi_scan.c Sun May 23 22:59:58 2004
> +++ linux-2.6.7-mm1/arch/i386/kernel/dmi_scan.c Sun May 23 23:00:53 2004
> @@ -348,17 +348,6 @@ static __init int swab_apm_power_in_minu
> }
>
> /*
> - * ASUS K7V-RM has broken ACPI table defining sleep modes
> - */
> -
> -static __init int broken_acpi_Sx(struct dmi_blacklist *d)
> -{
> - printk(KERN_WARNING "Detected ASUS mainboard with broken ACPI sleep table\n");
> - dmi_broken |= BROKEN_ACPI_Sx;
> - return 0;
> -}
> -
> -/*
> * Toshiba keyboard likes to repeat keys when they are not repeated.
> */
>
> @@ -712,12 +701,6 @@ static __initdata struct dmi_blacklist d
> { local_apic_kills_bios, "ASUS L3C", {
> MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
> MATCH(DMI_BOARD_NAME, "P4_L3C"),
> - NO_MATCH, NO_MATCH
> - } },
> -
> - { broken_acpi_Sx, "ASUS K7V-RM", { /* Bad ACPI Sx table */
> - MATCH(DMI_BIOS_VERSION,"ASUS K7V-RM ACPI BIOS Revision 1003A"),
> - MATCH(DMI_BOARD_NAME, "<K7V-RM>"),
> NO_MATCH, NO_MATCH
> } },

Maybe CC Len Brown on this, to see if he screams? :)

Jeff