From: Dave Hansen <haveblue@us.ibm.com>
To: linas@austin.ibm.com
Cc: paulus@au1.ibm.com, Paul Mackerras <paulus@samba.org>,
PPC64 External List <linuxppc64-dev@lists.linuxppc.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.6 PPC64: lockfix for rtas error log (third-times-a-charm?)]
Date: Thu, 01 Jul 2004 12:49:16 -0700 [thread overview]
Message-ID: <1088711355.21679.152.camel@nighthawk> (raw)
In-Reply-To: <20040701141931.E21634@forte.austin.ibm.com>
On Thu, 2004-07-01 at 12:19, linas@austin.ibm.com wrote:
> + /* Log the error in the unlikely case that there was one. */
> + if (unlikely(logit)) {
> + buff_copy = kmalloc (RTAS_ERROR_LOG_MAX, GFP_ATOMIC);
> + memcpy (buff_copy, rtas_err_buf, RTAS_ERROR_LOG_MAX);
> + }
You forgot to check the allocation for failure.
-- Dave
next prev parent reply other threads:[~2004-07-01 19:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-01 19:19 [PATCH] 2.6 PPC64: lockfix for rtas error log (third-times-a-charm?)] linas
2004-07-01 19:49 ` Dave Hansen [this message]
2004-07-01 20:31 ` linas
2004-07-01 20:39 ` Greg KH
2004-07-01 21:17 ` linas
-- strict thread matches above, loose matches on Subject: below --
2004-06-29 22:50 [PATCH] PPC64: lockfix for rtas error log linas
2004-06-30 1:44 ` Benjamin Herrenschmidt
2004-06-30 17:36 ` linas
2004-06-30 18:47 ` Benjamin Herrenschmidt
2004-06-30 20:31 ` [PATCH] 2.6 PPC64: lockfix for rtas error log (third-times-a-charm?) linas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1088711355.21679.152.camel@nighthawk \
--to=haveblue@us.ibm.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
--cc=paulus@au1.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox