Re: 2.6.7-mm7

Andrew Morton
2004-07-09T22:11:48Z

William Lee Irwin III <wli@holomorphy.com> wrote:
>
> SPLIT include/linux/autoconf.h -> include/config/*
> CHK include/linux/compile.h
> UPD include/linux/compile.h
> In file included from include/asm/sbus.h:10,
> from arch/sparc64/kernel/auxio.c:15:

It needs err.h.

btw, James, I'm unable to convince myself that
dma_mark_declared_memory_occupied() reserves enough pages if device_addr is
not page-aligned. Could you double-check that? If all callers are
expected to use a page-aligned address then a BUG_ON might be appropriate.
Or a comment.

diff -puN include/linux/dma-mapping.h~bk-dma-declare-coherent-memory-fix include/linux/dma-mapping.h
--- 25-sparc64/include/linux/dma-mapping.h~bk-dma-declare-coherent-memory-fix 2004-07-09 15:07:00.253229480 -0700
+++ 25-sparc64-akpm/include/linux/dma-mapping.h 2004-07-09 15:07:13.039285704 -0700
@@ -1,6 +1,8 @@
#ifndef _ASM_LINUX_DMA_MAPPING_H
#define _ASM_LINUX_DMA_MAPPING_H

+#include <linux/err.h>
+
/* These definitions mirror those in pci.h, so they can be used
* interchangeably with their PCI_ counterparts */
enum dma_data_direction {
_