From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Driver Core patches for 2.6.8-rc1
Date: Wed, 14 Jul 2004 17:18:22 -0700 [thread overview]
Message-ID: <10898507023964@kroah.com> (raw)
In-Reply-To: <20040715001651.GA20161@kroah.com>
ChangeSet 1.1757.22.6, 2004/06/22 16:24:54-07:00, akpm@osdl.org
[PATCH] raw.c cleanups
- pass the raw_config_request by reference, not by value.
- fix whitespace drainbamage
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
drivers/char/raw.c | 15 ++++++++-------
1 files changed, 8 insertions(+), 7 deletions(-)
diff -Nru a/drivers/char/raw.c b/drivers/char/raw.c
--- a/drivers/char/raw.c 2004-07-14 17:12:42 -07:00
+++ b/drivers/char/raw.c 2004-07-14 17:12:42 -07:00
@@ -125,11 +125,11 @@
return ioctl_by_bdev(bdev, command, arg);
}
-static void bind_device(struct raw_config_request rq)
+static void bind_device(struct raw_config_request *rq)
{
- class_simple_device_remove(MKDEV(RAW_MAJOR, rq.raw_minor));
- class_simple_device_add(raw_class, MKDEV(RAW_MAJOR, rq.raw_minor),
- NULL, "raw%d", rq.raw_minor);
+ class_simple_device_remove(MKDEV(RAW_MAJOR, rq->raw_minor));
+ class_simple_device_add(raw_class, MKDEV(RAW_MAJOR, rq->raw_minor),
+ NULL, "raw%d", rq->raw_minor);
}
/*
@@ -200,15 +200,16 @@
if (rq.block_major == 0 && rq.block_minor == 0) {
/* unbind */
rawdev->binding = NULL;
- class_simple_device_remove(MKDEV(RAW_MAJOR, rq.raw_minor));
+ class_simple_device_remove(MKDEV(RAW_MAJOR,
+ rq.raw_minor));
} else {
rawdev->binding = bdget(dev);
if (rawdev->binding == NULL)
err = -ENOMEM;
else {
__module_get(THIS_MODULE);
- bind_device(rq);
- }
+ bind_device(&rq);
+ }
}
up(&raw_mutex);
} else {
next prev parent reply other threads:[~2004-07-15 0:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-15 0:16 [BK PATCH] Driver Core patches for 2.6.8-rc1 Greg KH
2004-07-15 0:18 ` Greg KH [this message]
2004-07-15 0:18 ` [PATCH] " Greg KH
2004-07-15 0:18 ` Greg KH
2004-07-15 0:18 ` Greg KH
2004-07-15 0:18 ` Greg KH
2004-07-15 0:18 ` Greg KH
2004-07-15 0:18 ` Greg KH
2004-07-15 0:18 ` Greg KH
2004-07-15 0:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10898507023964@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox