public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: "Matthew C. Dobson [imap]" <colpatch@us.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: sched domains bringup race?
Date: Thu, 15 Jul 2004 19:13:46 -0700	[thread overview]
Message-ID: <1089944026.32312.47.camel@nighthawk> (raw)

I keep getting oopses for the non-boot CPU in find_busiest_group(). 
This occurs the first time that the CPU goes idle.  Those groups are set
up in sched_init_smp(), which is called after smp_init():

static int init(void * unused)
{
	...
        fixup_cpu_present_map();
        smp_init();
        sched_init_smp();

But, the idle threads for the secondary CPUs are initialized in
smp_init().  So, what happens when a CPU tries to schedule (using sched
domains) before sched_init_smp() completes?  I think it goes boom! :)

Anyway, I was thinking that we should just hold the runqueue lock on the
non-boot CPUs until the sched domain init code is done.  Does that sound
feasible?

-- Dave


             reply	other threads:[~2004-07-16  2:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-16  2:13 Dave Hansen [this message]
2004-07-16  3:03 ` sched domains bringup race? Nick Piggin
2004-07-16  3:30   ` Dave Hansen
2004-07-16  3:46     ` Nick Piggin
2004-07-16  5:27       ` Nick Piggin
2004-07-18 20:45 ` Keshavamurthy Anil S
2004-07-19  7:31   ` Nick Piggin
2004-07-22 21:55     ` Nathan Lynch
2004-07-22 23:23       ` Keshavamurthy Anil S
2004-07-23  0:33       ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1089944026.32312.47.camel@nighthawk \
    --to=haveblue@us.ibm.com \
    --cc=colpatch@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox