Re: [patch] kernel events layer

Andrew Morton
2004-07-24T05:13:07Z

Robert Love <rml@ximian.com> wrote:
>
> + buffer = (char *) get_zeroed_page(gfp_mask);

Why zeroed?

> + if (!buffer)
> + return -ENOMEM;
> +
> + snprintf(buffer, PAGE_SIZE, "From: %s\n", object);
> + len = strlen(buffer);
> + snprintf(buffer + len, PAGE_SIZE - len, "Signal: %s\n", signal);
> + len = strlen(buffer);

A single snprintf here would suit.