Re: [Lhms-devel] Re: [PATCH] memory hotplug for ia64 (linux-2.6.7) [0/2]

Dave Hansen
2004-07-27T16:39:45Z

On Tue, 2004-07-27 at 09:21, Fumitake ABE wrote:
> +#ifndef CONFIG_MEMHOTPLUG
> static struct early_node_data mem_data[NR_NODES] __initdata;
> +#else
> +static struct early_node_data mem_data[NR_NODES];
> +#endif

Instead of having a bunch of #ifdefs, it's best to just use __devinit
and __devinitdata. It will switch on CONFIG_HOTPLUG, but we've used it
in a bunch of places for hotplug CPU and everyone appears to like it.

-- Dave