Re: [patch] Latency Tracer, voluntary-preempt-2.6.8-rc4-O6

Peter Zijlstra
2004-08-13T10:29:54Z

On Fri, 2004-08-13 at 12:19 +0200, Ingo Molnar wrote:
> * Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
>
> > > arch/i386/kernel/traps.c: In function `do_nmi':
> > > arch/i386/kernel/traps.c:539: error: syntax error before "do"
>
> > This fixes it.
> >
> > --- ./include/asm-i386/hardirq.h~ 2004-08-13 11:17:38.668333125 +0200
> > +++ ./include/asm-i386/hardirq.h 2004-08-13 11:51:40.835968747 +0200
> > @@ -73,7 +73,7 @@
> > #define hardirq_endlock() do { } while (0)
> >
> > #define irq_enter() add_preempt_count(HARDIRQ_OFFSET)
> > -#define nmi_enter() (irq_enter())
> > +#define nmi_enter() irq_enter()
>
> yep - thx, this fix too will be in -O7. It seems this compilation error
> only happens with older gcc and i'm using 3.3.
>
> Ingo
FYI,

peter@twins ~ $ gcc --version
gcc (GCC) 3.3.4 20040623 (Gentoo Linux 3.3.4-r1, ssp-3.3.2-2, pie-8.7.6)
Copyright (C) 2003 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

and it hits here too.

--
Peter Zijlstra <a.p.zijlstra@chello.nl>