From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: torvalds@osdl.org, akpm@osdl.org, pluto@pld-linux.org,
linux-kernel@vger.kernel.org
Subject: Incorrect patch merged (Fwd: [PATCH] fdomain_cs needs ISA])
Date: Thu, 29 Jul 2004 16:19:19 +0100 [thread overview]
Message-ID: <1091114358.987.6.camel@localhost.localdomain> (raw)
fdomain_cs only needs PCMCIA, PCMCIA _is_ ISA bus with wrappers. The
problem arises because the driver uses isa_readb not ioremap when doing
bios scans that are only in the non PCMCIA code path. This broken patch
breaks fdomain_cs on platforms that it supports just fine.
The real fix is
--- drivers/scsi/fdomain.c~ 2004-07-29 17:17:10.133762816 +0100
+++ drivers/scsi/fdomain.c 2004-07-29 17:17:10.133762816 +0100
@@ -681,6 +681,7 @@
static int fdomain_isa_detect( int *irq, int *iobase )
{
+#ifndef PCMCIA
int i, j;
int base = 0xdeadbeef;
int flag = 0;
@@ -786,6 +787,9 @@
*iobase = base;
return 1; /* success */
+#else
+ return 0;
+#endif
}
/* PCI detection function: int fdomain_pci_bios_detect(int* irq, int*
-----Forwarded Message-----
> From: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
> To: bk-commits-head@vger.kernel.org
> Subject: [PATCH] fdomain_cs needs ISA
> Date: Thu, 29 Jul 2004 06:02:05 +0000
>
> ChangeSet 1.1844, 2004/07/28 23:02:05-07:00, pluto@pld-linux.org
>
> [PATCH] fdomain_cs needs ISA
>
> drivers/scsi/pcmcia/fdomain_cs.ko needs unknown symbol isa_memcpy_fromio
> drivers/scsi/pcmcia/fdomain_cs.ko needs unknown symbol isa_readb
>
> iirc the isa bus isn't available on ppc.
>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
>
>
>
> Kconfig | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
>
> diff -Nru a/drivers/scsi/pcmcia/Kconfig b/drivers/scsi/pcmcia/Kconfig
> --- a/drivers/scsi/pcmcia/Kconfig 2004-07-29 00:17:32 -07:00
> +++ b/drivers/scsi/pcmcia/Kconfig 2004-07-29 00:17:32 -07:00
> @@ -17,7 +17,7 @@
>
> config PCMCIA_FDOMAIN
> tristate "Future Domain PCMCIA support"
> - depends on m
> + depends on m && ISA
> help
> Say Y here if you intend to attach this type of PCMCIA SCSI host
> adapter to your computer.
> -
> To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
reply other threads:[~2004-07-29 16:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1091114358.987.6.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pluto@pld-linux.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox