From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Andi Kleen <ak@suse.de>, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Improve pci_alloc_consistent wrapper on preemptive kernels
Date: 30 Jul 2004 16:13:39 -0400 [thread overview]
Message-ID: <1091218419.1968.46.camel@mulgrave> (raw)
In-Reply-To: <20040730130238.0f68f5e7.akpm@osdl.org>
On Fri, 2004-07-30 at 16:02, Andrew Morton wrote:
> We're paying for past sins here. I think it would be better to create a
> new version of pci_alloc_consistent() which takes gfp_flags, then migrate
> the drivers you care about to use it. That way the benefit is available on
> non-preempt kernels too.
>
> The ultimate aim of course would be to deprecate then remove the old
> function.
True, that's why it was added for dma_alloc_coherent().
Is there any need for a new wrapper? Why not just use
dma_alloc_coherent() from now on?
James
next prev parent reply other threads:[~2004-07-30 20:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-30 17:02 [PATCH] Improve pci_alloc_consistent wrapper on preemptive kernels Andi Kleen
2004-07-30 17:16 ` Jeff Garzik
2004-07-30 17:43 ` Andi Kleen
2004-07-30 18:07 ` Jeff Garzik
2004-07-30 18:47 ` Takashi Iwai
2004-07-30 19:28 ` Takashi Iwai
2004-07-30 21:42 ` Andi Kleen
2004-07-30 20:02 ` Andrew Morton
2004-07-30 20:13 ` James Bottomley [this message]
2004-07-30 20:20 ` Andrew Morton
2004-07-30 20:28 ` James Bottomley
[not found] <2nJ3t-34a-39@gated-at.bofh.it>
[not found] ` <2nJmP-3eq-9@gated-at.bofh.it>
[not found] ` <2nJG8-3p6-21@gated-at.bofh.it>
[not found] ` <2nK9b-3PM-17@gated-at.bofh.it>
2004-07-30 18:34 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1091218419.1968.46.camel@mulgrave \
--to=james.bottomley@hansenpartnership.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox