From: Rusty Russell <rusty@rustcorp.com.au>
To: Dominik Brodowski <linux@dominikbrodowski.de>
Cc: Greg KH <greg@kroah.com>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [UPDATED PATCH 1/2] export module parameters in sysfs for modules _and_ built-in code
Date: Tue, 03 Aug 2004 10:27:41 +1000 [thread overview]
Message-ID: <1091492861.426.112.camel@bach> (raw)
In-Reply-To: <20040802214710.GB7772@dominikbrodowski.de>
On Tue, 2004-08-03 at 07:47, Dominik Brodowski wrote:
> Thanks for your feedback, Rusty.
Hey, thanks for the code!
> > > +/* Needs to be before __initcall(module_init) */
> > > +fs_initcall(param_sysfs_init);
> >
> > That's horrible. And I think the initcall in module.c should be removed
> > in your second patch, no?
>
> Actually, it could have remained __initcall... and the one in module.c is
> needed as we still register a module subsystem. This updated patch doesn't
> add an own initcall in params.c, though, but rather param_sysfs_init() gets
> called by module_init.
It's logically separate, IMHO. I'm thinking about CONFIG_MODULES=n
here...
Cheers,
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
next prev parent reply other threads:[~2004-08-03 0:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-01 16:54 [RFC] [PATCH 1/2] export module parameters in sysfs for modules _and_ built-in code Dominik Brodowski
2004-08-02 5:59 ` Rusty Russell
2004-08-02 21:47 ` [UPDATED PATCH " Dominik Brodowski
2004-08-03 0:27 ` Rusty Russell [this message]
2004-08-13 17:08 ` Patrick Mansfield
2004-08-18 19:55 ` Martin Schlemmer
2004-08-20 13:46 ` Tonnerre
2004-08-29 13:14 ` Dominik Brodowski
2004-08-29 13:49 ` [UPDATED PATCH 1/2] export module parameters in sysfs for modules _and_ built-in code [u] Martin Schlemmer [c]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1091492861.426.112.camel@bach \
--to=rusty@rustcorp.com.au \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox