From: Nigel Cunningham <ncunningham@linuxmail.org>
To: Zwane Mwaikambo <zwane@linuxpower.ca>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: MTRR driver model support broken on SMP.
Date: Wed, 04 Aug 2004 15:22:47 +1000 [thread overview]
Message-ID: <1091596967.3189.86.camel@laptop.cunninghams> (raw)
In-Reply-To: <Pine.LNX.4.58.0408040119270.19619@montezuma.fsmlabs.com>
Hi.
On Wed, 2004-08-04 at 15:23, Zwane Mwaikambo wrote:
> On Wed, 4 Aug 2004, Nigel Cunningham wrote:
>
> > MTRR driver support is broken on SMP because it calls smp functions with
> > interrupts disabled, but interrupts should be disabled because it is
> > called via device_power_up.
> >
> > Badness in smp_call_function at arch/i386/kernel/smp.c:565
> > [<c0107f88>] dump_stack+0x1e/0x20
> > [<c0116927>] smp_call_function+0x12b/0x137
> > [<c011063f>] set_mtrr+0x67/0x121
> > [<c0110c9b>] mtrr_restore+0x4f/0x73
> > [<c0219c0f>] sysdev_resume+0x6f/0xf0
> > [<c021d591>] device_power_up+0x8/0xf
>
> Looking at this i'm really curious as to whether we need to bother at all,
> can you remove the mtrr restore code and then compare /proc/mtrr before
> and after suspending.
I haven't had problems but do remember 2.4 users who had trouble with X
before code to save and restore mtrrs was added.
Regards,
Nigel
next prev parent reply other threads:[~2004-08-04 5:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-04 2:07 MTRR driver model support broken on SMP Nigel Cunningham
2004-08-04 5:23 ` Zwane Mwaikambo
2004-08-04 5:22 ` Nigel Cunningham [this message]
2004-08-04 5:31 ` Zwane Mwaikambo
2004-08-04 5:31 ` Nigel Cunningham
2004-08-04 21:15 ` Zwane Mwaikambo
2004-08-04 22:24 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1091596967.3189.86.camel@laptop.cunninghams \
--to=ncunningham@linuxmail.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox