public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kasper Sandberg <lkml@metanurb.dk>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andi Kleen <ak@muc.de>, James Morris <jmorris@redhat.com>,
	LKML Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Re-implemented i586 asm AES (updated)
Date: Sat, 07 Aug 2004 09:49:45 +0200	[thread overview]
Message-ID: <1091864985.9992.0.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.58.0408060941550.24588@ppc970.osdl.org>

i dont know anything at all about this, but wouldnt it be possible to
optimize it even more, if there were a version for each cpu, like one
for athlon-xp and one for p4?

On Fri, 2004-08-06 at 09:43 -0700, Linus Torvalds wrote:
> 
> On Fri, 6 Aug 2004, Andi Kleen wrote:
> > 
> > You could use .altinstructions to patch a jump in at runtime
> > based on CPU capabilities. Assuming MMX is really faster of course.
> 
> I seriously doubt that the MMX code could be faster.
> 
> The only MMX code in the original was saving some integer contents to a 
> scratch MMX register rather than saving to memory. There's _no_ way that 
> is faster, especially since in the kernel it would require us much extra 
> work to first check that the FP context is safed. Even _without_ the extra 
> work I simply cannot imagine that a "movd reg,mmx" is faster than a plain 
> "movl reg,stackslot". 
> 
> 		Linus
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


  parent reply	other threads:[~2004-08-07  7:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2qbyt-1Op-45@gated-at.bofh.it>
     [not found] ` <2qemF-3Pj-49@gated-at.bofh.it>
2004-08-06 15:09   ` [PATCH] Re-implemented i586 asm AES (updated) Andi Kleen
2004-08-06 16:17     ` James Morris
2004-08-06 16:38       ` David Woodhouse
2004-08-06 16:44       ` Jörn Engel
2004-08-06 16:43     ` Linus Torvalds
2004-08-06 17:17       ` Ben Pfaff
2004-08-07  7:49       ` Kasper Sandberg [this message]
2004-08-07 20:26         ` Andi Kleen
2004-08-09 19:38       ` dean gaudet
2004-08-06 12:00 [PATCH] Re-implemented i586 asm AES Marc Ballarin
2004-08-06 14:52 ` [PATCH] Re-implemented i586 asm AES (updated) James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1091864985.9992.0.camel@localhost \
    --to=lkml@metanurb.dk \
    --cc=ak@muc.de \
    --cc=jmorris@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox