From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Vincent Hanquez <tab@snarc.org>
Cc: Paul Mackerras <paulus@samba.org>,
lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH][RESENT] remove hardcoded offsets from ppc asm
Date: Sun, 08 Aug 2004 09:32:12 +1000 [thread overview]
Message-ID: <1091921531.14102.2.camel@gaston> (raw)
In-Reply-To: <20040807151838.GA6760@snarc.org>
On Sun, 2004-08-08 at 01:18, Vincent Hanquez wrote:
> Hi LKML,
>
> This patch removes hardcoded offsets from ppc asm.
> It generate offsets for thread_info structure instead of hardcoding them.
>
> Please apply or comments,
>
> Signed-off-by: Vincent Hanquez <tab@snarc.org>
I have nothing against the idea, but why the hell did you change the
constant names, turning them partially to lowercase ? They are just
fine beeing uppercase, this is more consistent, and that would
reduce the size of your patch signficantly.
Ben.
next prev parent reply other threads:[~2004-08-07 23:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-07 15:18 [PATCH][RESENT] remove hardcoded offsets from ppc asm Vincent Hanquez
2004-08-07 23:32 ` Benjamin Herrenschmidt [this message]
2004-08-08 10:25 ` Vincent Hanquez
2004-08-08 10:25 ` Benjamin Herrenschmidt
2004-08-08 10:52 ` Vincent Hanquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1091921531.14102.2.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=tab@snarc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox