From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: GOTO Masanori <gotom@debian.or.jp>
Cc: Paul Mackerras <paulus@samba.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Remove unneeded #ifdef kernel from ppc unaligned.h
Date: Tue, 10 Aug 2004 08:37:31 +1000 [thread overview]
Message-ID: <1092091050.14102.50.camel@gaston> (raw)
In-Reply-To: <81pt60680s.wl@omega.webmasters.gr.jp>
On Mon, 2004-08-09 at 18:16, GOTO Masanori wrote:
> At Mon, 09 Aug 2004 18:07:45 +1000,
> Benjamin Herrenschmidt wrote:
> > On Mon, 2004-08-09 at 15:16, GOTO Masanori wrote:
> > > This patch removes unneeded #ifdef __KERNEL__ from ppc unaligned.h.
> > > There's no reason to enclose __KERNEL__, similar to other
> > > architectures. It also fixes the compilation failure building
> > > userland helper application reiserfsprogs on ppc which includes
> > > asm/unaligned.h.
> >
> > Well, userland isn't supposed to use those ...
>
> I know. It's just side effect. But there's no reason to enclose
> #ifdef __KERNEL__.
Hrm... I'd say there is no reason not to enclose it in it, but I'll
let Paul make a final decision here.
Ben.
prev parent reply other threads:[~2004-08-09 22:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-09 5:16 [PATCH] Remove unneeded #ifdef kernel from ppc unaligned.h GOTO Masanori
2004-08-09 8:07 ` Benjamin Herrenschmidt
2004-08-09 8:16 ` GOTO Masanori
2004-08-09 22:37 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1092091050.14102.50.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=gotom@debian.or.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox