Re: Allow userspace do something special on overtemp

Len Brown
2004-08-12T14:28:25Z

On Thu, 2004-08-12 at 03:40, Pavel Machek wrote:
> Hi!
>
> > I think I'd rather see the calls to usermode deleted
> > instead of extended -- unless there is a reason that
> > the general event -> acpid method can't work.
>
> See above, switching to acpid would break all the existing
> setups... in stable series.

ah, the price of progress.

I'm confident that the distros can figure out how to
update the (neglected) acpid scripts at the same time as
(or before) the kernel update.

If they can't, then ACPI critical shutdown will fail
(maybe on some systems not such a bad thing;-)
and TM1 will kick in, and if that doesn't work, TM2
will kick in, and if that doesn't work the processor
will disable itself.

In practice, the only time this will happen is due to
an erroneous thermal sensor reading, or when somebody
loses their CPU fan; and it is the exact same path
that the system would take if somebody booted with acpi=off.

> Also notice that thermal.c is so "interestingly" written that my patch
> does not actually make it longer by deleting useless defines etc...

Conserving syntax is certainly laudable,
but conserving semantics is even more valuable.

I do thank you for identifying this issue and
proposing change.

-Len