From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268963AbUHMEWp (ORCPT ); Fri, 13 Aug 2004 00:22:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268964AbUHMEWp (ORCPT ); Fri, 13 Aug 2004 00:22:45 -0400 Received: from viper.oldcity.dca.net ([216.158.38.4]:24971 "HELO viper.oldcity.dca.net") by vger.kernel.org with SMTP id S268963AbUHMEWm (ORCPT ); Fri, 13 Aug 2004 00:22:42 -0400 Subject: Re: [patch] Latency Tracer, voluntary-preempt-2.6.8-rc4-O6 From: Lee Revell To: Ingo Molnar Cc: linux-kernel , Felipe Alfaro Solana , Florian Schmidt In-Reply-To: <1092369242.2769.1.camel@mindpipe> References: <20040726082330.GA22764@elte.hu> <1090830574.6936.96.camel@mindpipe> <20040726083537.GA24948@elte.hu> <1090832436.6936.105.camel@mindpipe> <20040726124059.GA14005@elte.hu> <20040726204720.GA26561@elte.hu> <20040729222657.GA10449@elte.hu> <20040801193043.GA20277@elte.hu> <20040809104649.GA13299@elte.hu> <20040810132654.GA28915@elte.hu> <20040812235116.GA27838@elte.hu> <1092360317.1304.72.camel@mindpipe> <1092360704.1304.76.camel@mindpipe> <1092364786.877.1.camel@mindpipe> <1092369242.2769.1.camel@mindpipe> Content-Type: text/plain Message-Id: <1092370997.2769.5.camel@mindpipe> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Fri, 13 Aug 2004 00:23:18 -0400 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2004-08-12 at 23:54, Lee Revell wrote: > On Thu, 2004-08-12 at 22:39, Lee Revell wrote: > > On Thu, 2004-08-12 at 21:31, Lee Revell wrote: > > > On Thu, 2004-08-12 at 21:25, Lee Revell wrote: > > > > Does not compile. For each module I get: > > > > > > > > > > Never mind, stupid mistake on my part. > > > > > > > Argh, this is actually a fatal bug, and not a mistake on my part. > > mcount is an unknown symbol, and make modules_install does not like > > that. > > > > I checked Module.symvers and it is not in there, but this seems to be a > > generated file, and I have no idea why mcount does not appear. > > > > I think appending this to i386_ksyms.c fixes the problem: > > #ifdef CONFIG_PREEMPT_TIMING > EXPORT_SYMBOL(mcount); > #endif > > Possibly that should be CONFIG_LATENCY_TRACE. I believe this is the correct patch, based on arch/sparc64/kernel/sparc64_ksyms.c. Ingo, are you using a sparc64 for your testing? --- arch/i386/kernel/i386_ksyms.c.orig 2004-08-13 00:18:51.000000000 -0400 +++ arch/i386/kernel/i386_ksyms.c 2004-08-13 00:19:46.000000000 -0400 @@ -59,6 +59,11 @@ extern unsigned long cpu_khz; extern unsigned long get_cmos_time(void); +#if defined(CONFIG_MCOUNT) +extern void mcount(void); +EXPORT_SYMBOL_NOVERS(mcount); +#endif + /* platform dependent support */ EXPORT_SYMBOL(boot_cpu_data); EXPORT_SYMBOL(MCA_bus);